Add number lookup to communication phonenumbers #31053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericasp16
requested review from
miguhern,
whisper6284,
RoyHerrod and
danielav7
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
2 tasks
ericasp16
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jul 20, 2023
### Packages impacted by this PR communication-phone-numbers ### Issues associated with this PR Azure/azure-sdk#6321 ### Describe the problem that is addressed by this PR Adding number lookup endpoint to the SDK ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ Azure/azure-sdk-for-java#35674 Azure/azure-sdk-for-python#31053 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [X] Added impacted package name to the issue description - [n/a] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
guoqing2023
reviewed
Aug 3, 2023
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Show resolved
Hide resolved
guoqing2023
approved these changes
Aug 3, 2023
ericasp16
added a commit
that referenced
this pull request
Jan 29, 2024
GA implementation of the number lookup feature. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. These changes are going into a branch to wait until we're ready to do our final bug bashing and eventually merging and shipping the feature. ---------- * Add number lookup to communication phonenumbers (#31053) * update swagger and regenerate using autorest * update internal operation tests * regenerate autorest, add and record tests * Update changelog * update tests to account for phone number sanitization, update test recordings * update autorest generation * updates based on review comments * udpate tests/recordings * fix linting error * fix lint errors and test for async * update test recordings * update changelog, minor fixes to tests, and update to the recordings * update version in changelog to beta version * update version * update changelog * update changelog * update generated files * update to GA verison for review * updated based on SDK review feedback
ericasp16
added a commit
that referenced
this pull request
Mar 27, 2024
* Number lookup ga (#33203) GA implementation of the number lookup feature, releasing as a private preview first. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. ---------- * Add number lookup to communication phonenumbers (#31053) * update swagger and regenerate using autorest * update internal operation tests * regenerate autorest, add and record tests * Update changelog * update tests to account for phone number sanitization, update test recordings * update autorest generation * updates based on review comments * udpate tests/recordings * fix linting error * fix lint errors and test for async * update test recordings * update changelog, minor fixes to tests, and update to the recordings * update version in changelog to beta version * update version * update changelog * update changelog * update generated files * update to GA verison for review * updated based on SDK review feedback * update to preview version, regenerate files with autorest * update test recordings * fix build issues * fix pylint errors, update tests * try fixing up tests * comment out failing call-automation test * fix pylint issues * update test files * Update setup.py upgrade the azure.core package --------- Co-authored-by: guoqing2023 <[email protected]>
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-js
that referenced
this pull request
Apr 11, 2024
communication-phone-numbers Azure/azure-sdk#6321 Adding number lookup endpoint to the SDK there are more than one possible design, why was the one in this PR chosen? Yes Azure/azure-sdk-for-java#35674 Azure/azure-sdk-for-python#31053 request PRs)_ - [X] Added impacted package name to the issue description - [n/a] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Number Lookout method to the Phone Numbers client to support public preview of the new feature. See this issue for information about API changes: Azure/azure-rest-api-specs#23060
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines