Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IC3 ACS Management GW] API Review #23060

Closed
azure-sdk opened this issue Mar 13, 2023 · 2 comments · Fixed by #23053
Closed

[IC3 ACS Management GW] API Review #23060

azure-sdk opened this issue Mar 13, 2023 · 2 comments · Fixed by #23053
Assignees
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.

Comments

@azure-sdk
Copy link
Collaborator

New API Review meeting has been requested.

Service Name: IC3 ACS Management GW
Review Created By: Erica Sponsler (SHE/HER)
Review Date: 4/11/2023 1:00 PM PT
PR: #23053
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided

Description: This is a new feature that would allow ACS customers to look up information about a recipient phone number before using ACS services (e.g. SMS) to contact that phone number.

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@azure-sdk azure-sdk added the API Review Scoping This is an issue that will track work on a specific set of API changes. label Mar 13, 2023
@ericasp16 ericasp16 added APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. and removed APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Mar 17, 2023
@azure-sdk
Copy link
Collaborator Author

Meeting updated by Erica Sponsler (SHE/HER)

Service Name: IC3 ACS Management GW
Review Created By: Erica Sponsler (SHE/HER)
Review Date: 04/11/2023 01:00 PM PT
PR: #23053
Hero Scenarios Link: here
Core Concepts Doc Link: here

Description: This is a new feature that would allow ACS customers to look up information about a recipient phone number before using ACS services (e.g. SMS) to contact that phone number.

Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

@mikekistler
Copy link
Member

Notes from API review meeting 4/11/23

  • New operation will return information about any phone number, not just ACS managed ones
  • maybe '/operators/:searchPhoneNumbers'
    • operators vs operatorInfo vs ?? -- a collection name
    • Only one level of name space
  • Paging? Probably will never need it. Leave this to the service team.
  • mmc and mcc ?? should consider if these are well known enough names
  • Schema name for PhoneNumberInformation ?? OperatorInfo ?? -- make it match the collection name
  • What about the other previews? 2022-01-11-preview, 2022-06-01-preview ??
    • Need to get this straightened out
  • Ignore the lintDiff messages since they look broken -- @mikekistler to open an issue

Approved for private preview. Please request a new review for public preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Scoping This is an issue that will track work on a specific set of API changes.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants