Update number lookup feature from GA to Preview #34547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GA implementation of the number lookup feature. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. These changes are going into a branch to wait until we're ready to do our final bug bashing and eventually merging and shipping the feature. ---------- * Add number lookup to communication phonenumbers (Azure#31053) * update swagger and regenerate using autorest * update internal operation tests * regenerate autorest, add and record tests * Update changelog * update tests to account for phone number sanitization, update test recordings * update autorest generation * updates based on review comments * udpate tests/recordings * fix linting error * fix lint errors and test for async * update test recordings * update changelog, minor fixes to tests, and update to the recordings * update version in changelog to beta version * update version * update changelog * update changelog * update generated files * update to GA verison for review * updated based on SDK review feedback
|
API change check API changes are not detected in this pull request. |
ericasp16
requested review from
miguhern,
whisper6284,
RoyHerrod and
danielav7
as code owners
guoqing2023
approved these changes
Mar 14, 2024
ericasp16
changed the base branch from
main
to
release/azure-communication-phonenumbers/preview-main-python
ericasp16
requested review from
scbedd,
weshaggard,
benbp,
ChenxiJiang333,
msyyc,
iscai-msft,
johngallardo,
Aashish93-stack and
sjiherzig
as code owners
ericasp16
removed request for
xinlian12,
msyyc,
sarkar-rajarshi,
swathipil,
yifan-zhou922,
jalauzon-msft,
TajiHarrisMicrosoft,
maximrytych-ms,
l0lawrence,
kdestin,
vincenttran-msft,
besh2014,
albertofori,
nancy-mejia,
Aashish93-stack,
MilesHolland,
maykumar-msft,
stanley-msft,
gfeitosa-msft,
mjafferi-msft,
phermanov-msft,
ChenxiJiang333,
ilyapaliakou-msft,
jairmyree,
nisha-bhatia,
gulopesd,
maorleger and
billwert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Number Lookup public preview to include the Number Format features we've been preparing for GA.
Azure/azure-rest-api-specs#27799
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines