Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyVault secrets do not correctly set all properties #13611

Closed
maorleger opened this issue Feb 5, 2021 · 1 comment · Fixed by #13614
Closed

KeyVault secrets do not correctly set all properties #13611

maorleger opened this issue Feb 5, 2021 · 1 comment · Fixed by #13614
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@maorleger
Copy link
Member

Specifically missing was enabled but I audited all the properties and added them back.

@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. KeyVault labels Feb 5, 2021
@maorleger maorleger added this to the [2021] February milestone Feb 5, 2021
@maorleger maorleger self-assigned this Feb 5, 2021
@maorleger
Copy link
Member Author

Closed with #13614

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue May 11, 2021
Network february release (Azure#14333)

* Adds base for updating Microsoft.Network from version stable/2020-11-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* init (Azure#13496)

Co-authored-by: matyang222 <[email protected]>

* Swagger change for CustomIpPrefix. Adding four new attributes.  (Azure#13456)

* update swagger

* fix apiversion

* fix

* add

Co-authored-by: Weiheng Li <[email protected]>

* typo: paramter in applicationGateway.json (Azure#13538)

* VPN NAT for Virtual Network Gateway feature changes(networkFeb) (Azure#13481)

* commit1

* commit2

* resolving comments

* pythonMd

Co-authored-by: Khushboo Baheti <[email protected]>

* fix virtual network resource (Azure#13570)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… (Azure#13519)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Properties

* Updated the type from string to integer, added a non-null example

* Added missing format for 'integer' type

* Add new failedMessage property for CustomIpPrefix (Azure#13607)

* update swagger

* fix apiversion

* fix

* add

* add failedreason property

* update swagger

* fix apiversion

* fix

* add failedreason property

* update

Co-authored-by: Weiheng Li <[email protected]>

* Added Preferred Routing Gateway Support (Azure#13611)

* Feature: Address space update in peered vNets (Azure#13521)

* Adding new fields and operation to support the address space update in peered vNets

Adding new fields and operation to support the address space update in peered vNets

* Adding the new query param in the example

As per the review comment, adding the new query param in the example request response of swagger.

* Adding the new query param in examples

Adding the new query param in examples

* Restricting the sync param

Restricting the sync param to hold only true as value. We never need to send false.

Co-authored-by: Hari Prasad Perabattula <[email protected]>

* Remove max file size limit enforcement as it is done in NRP (Azure#13679)

* Tesha/fix waf policy examples crs version (Azure#13697)

* Remove max file size limit enforcement as it is done in NRP

* Update the CRS version in the examples to reflect latest

* Fix (Azure#13734)

Co-authored-by: Khushboo Baheti <[email protected]>

* Swagger for NRP's VipSwap operation (Azure#13639)

* Swagger for NRP's VipSwap operation

* Fixing validation errors

* minor fix

* Adding api version

* Remove required (Azure#13969)

Co-authored-by: Will Ehrich <[email protected]>

* Hotfix extended location parameter hierarchy (Azure#13864)

* add to feb branch

* delete project name reference

* expose two new client cert properties: validatedCertData, clientCertIssuerDN (Azure#13989)

* adding workloadType property for Baremetal scenarios (Azure#14101)

* Added bastion sku (Azure#14248)

* fix nrp resources based on s360 checks (Azure#14219)

* Adding Azure Network Manager association to the EffectiveNetworkSecurityGroups API (Azure#14265)

* Added Azure Network Manager association to the EffectiveNetworkSecurityGroupAssociation

* Adding example for networkManager response in the EffectiveNSG call

* Add deleteOption to PublicIPAddress (Azure#14343)

* Add deleteOption to PublicIPAddress

* run validators

Co-authored-by: Bashar Gharaibeh <[email protected]>

Co-authored-by: Matthew Yang <[email protected]>
Co-authored-by: matyang222 <[email protected]>
Co-authored-by: Tom Li <[email protected]>
Co-authored-by: Weiheng Li <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: guptas14 <[email protected]>
Co-authored-by: Satya-anshu <[email protected]>
Co-authored-by: arvenka <[email protected]>
Co-authored-by: Hari Prasad Perabattula <[email protected]>
Co-authored-by: Hari Prasad Perabattula <[email protected]>
Co-authored-by: tejasshah7 <[email protected]>
Co-authored-by: shnaya434 <[email protected]>
Co-authored-by: William Ehrich <[email protected]>
Co-authored-by: Will Ehrich <[email protected]>
Co-authored-by: litchiyangMSFT <[email protected]>
Co-authored-by: biaogao <[email protected]>
Co-authored-by: bhbhise <[email protected]>
Co-authored-by: mscorp-buchen <[email protected]>
Co-authored-by: Arpit Agarwal <[email protected]>
Co-authored-by: basharg <[email protected]>
Co-authored-by: Bashar Gharaibeh <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant