Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] Improve log messages - SBAdministrationClient #13989

Closed
HarshaNalluru opened this issue Feb 26, 2021 · 2 comments
Closed

[Service Bus] Improve log messages - SBAdministrationClient #13989

HarshaNalluru opened this issue Feb 26, 2021 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus

Comments

@HarshaNalluru
Copy link
Member

Observed these logs while testing (part of the logs while recreating a queue)
image
To repro: Just enable logging and perform create get and delete operations.

TODO: Improve the logs - especially the highlighted lines.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 26, 2021
@HarshaNalluru HarshaNalluru changed the title [Service Bus] Improve log messages [Service Bus] Improve log messages - SBAdministrationClient Feb 26, 2021
@HarshaNalluru HarshaNalluru mentioned this issue Feb 26, 2021
Merged
13 tasks
@ramya-rao-a ramya-rao-a added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus labels Feb 26, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 26, 2021
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 26, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 26, 2021
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Feb 26, 2021
ghost pushed a commit that referenced this issue Mar 23, 2021
@HarshaNalluru
[Service Bus] Session Receiver (Both batching and streaming) during a…
70d860e 
… disconnect (#13956)

### Issue #8875

### What's in the PR
"disconnect"/refresh logic added before did not cover the session scenarios. 
This PR attempts to tackle the batching receiver for sessions upon "disconnect" scenarios to have a smooth-resolution/throw-errors based on the receiveMode.
Streaming receiver calls processError with SessionLockLost and closes the link

### receiveMessages - Scenarios to handle/test
- [x] throws "session lock has expired" after a disconnect
- [x] returns messages if drain is in progress (receiveAndDelete)
- [x] throws an error if drain is in progress (peekLock)
- [x] returns messages if receive in progress (receiveAndDelete)
- [x] throws an error if receive is in progress (peekLock)

### Streaming receiver
- [x] Test - calls processError and closes the link
 
### TODO
- [x] Cover the scenarios above
- [x] Tests
- [x] Bug fix - number of receivers - #13990
- [x] Changelog
- [x] Streaming receiver - ~~beyond the scope of this PR~~ #14212
- [ ] Bad log messages #13989 - beyond the scope of this PR
- [ ] Stress testing plan for disconnect - #13988 - beyond the scope of this PR

Fixes #8875
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this issue Apr 26, 2021
@HarshaNalluru @vindicatesociety
[Service Bus] Session Receiver (Both batching and streaming) during a…
0cce81b 
… disconnect (Azure#13956)

### Issue Azure#8875

### What's in the PR
"disconnect"/refresh logic added before did not cover the session scenarios. 
This PR attempts to tackle the batching receiver for sessions upon "disconnect" scenarios to have a smooth-resolution/throw-errors based on the receiveMode.
Streaming receiver calls processError with SessionLockLost and closes the link

### receiveMessages - Scenarios to handle/test
- [x] throws "session lock has expired" after a disconnect
- [x] returns messages if drain is in progress (receiveAndDelete)
- [x] throws an error if drain is in progress (peekLock)
- [x] returns messages if receive in progress (receiveAndDelete)
- [x] throws an error if receive is in progress (peekLock)

### Streaming receiver
- [x] Test - calls processError and closes the link
 
### TODO
- [x] Cover the scenarios above
- [x] Tests
- [x] Bug fix - number of receivers - Azure#13990
- [x] Changelog
- [x] Streaming receiver - ~~beyond the scope of this PR~~ Azure#14212
- [ ] Bad log messages Azure#13989 - beyond the scope of this PR
- [ ] Stress testing plan for disconnect - Azure#13988 - beyond the scope of this PR

Fixes Azure#8875
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue May 11, 2021
@matyang22 @gitlwh
@nschonni @Khushboo-Baheti @guptas14 @Satya-anshu @arvenka @harics24 @tejasshah7 @shnaya434 @wdehrich @litchiyangMSFT @3quanfeng @bhbhise @mscorp-buchen @aragar740 @basharg
CodeGen from PR 14333 in Azure/azure-rest-api-specs
4c14411 
Network february release (Azure#14333)

* Adds base for updating Microsoft.Network from version stable/2020-11-01 to version 2021-02-01

* Updates readme

* Updates API version in new specs and examples

* init (Azure#13496)

Co-authored-by: matyang222 <[email protected]>

* Swagger change for CustomIpPrefix. Adding four new attributes.  (Azure#13456)

* update swagger

* fix apiversion

* fix

* add

Co-authored-by: Weiheng Li <[email protected]>

* typo: paramter in applicationGateway.json (Azure#13538)

* VPN NAT for Virtual Network Gateway feature changes(networkFeb) (Azure#13481)

* commit1

* commit2

* resolving comments

* pythonMd

Co-authored-by: Khushboo Baheti <[email protected]>

* fix virtual network resource (Azure#13570)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Proper… (Azure#13519)

* Added a new feature FlowTimeoutInMinutes under Virtual Network Properties

* Updated the type from string to integer, added a non-null example

* Added missing format for 'integer' type

* Add new failedMessage property for CustomIpPrefix (Azure#13607)

* update swagger

* fix apiversion

* fix

* add

* add failedreason property

* update swagger

* fix apiversion

* fix

* add failedreason property

* update

Co-authored-by: Weiheng Li <[email protected]>

* Added Preferred Routing Gateway Support (Azure#13611)

* Feature: Address space update in peered vNets (Azure#13521)

* Adding new fields and operation to support the address space update in peered vNets

Adding new fields and operation to support the address space update in peered vNets

* Adding the new query param in the example

As per the review comment, adding the new query param in the example request response of swagger.

* Adding the new query param in examples

Adding the new query param in examples

* Restricting the sync param

Restricting the sync param to hold only true as value. We never need to send false.

Co-authored-by: Hari Prasad Perabattula <[email protected]>

* Remove max file size limit enforcement as it is done in NRP (Azure#13679)

* Tesha/fix waf policy examples crs version (Azure#13697)

* Remove max file size limit enforcement as it is done in NRP

* Update the CRS version in the examples to reflect latest

* Fix (Azure#13734)

Co-authored-by: Khushboo Baheti <[email protected]>

* Swagger for NRP's VipSwap operation (Azure#13639)

* Swagger for NRP's VipSwap operation

* Fixing validation errors

* minor fix

* Adding api version

* Remove required (Azure#13969)

Co-authored-by: Will Ehrich <[email protected]>

* Hotfix extended location parameter hierarchy (Azure#13864)

* add to feb branch

* delete project name reference

* expose two new client cert properties: validatedCertData, clientCertIssuerDN (Azure#13989)

* adding workloadType property for Baremetal scenarios (Azure#14101)

* Added bastion sku (Azure#14248)

* fix nrp resources based on s360 checks (Azure#14219)

* Adding Azure Network Manager association to the EffectiveNetworkSecurityGroups API (Azure#14265)

* Added Azure Network Manager association to the EffectiveNetworkSecurityGroupAssociation

* Adding example for networkManager response in the EffectiveNSG call

* Add deleteOption to PublicIPAddress (Azure#14343)

* Add deleteOption to PublicIPAddress

* run validators

Co-authored-by: Bashar Gharaibeh <[email protected]>

Co-authored-by: Matthew Yang <[email protected]>
Co-authored-by: matyang222 <[email protected]>
Co-authored-by: Tom Li <[email protected]>
Co-authored-by: Weiheng Li <[email protected]>
Co-authored-by: Nick Schonning <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: Khushboo Baheti <[email protected]>
Co-authored-by: guptas14 <[email protected]>
Co-authored-by: Satya-anshu <[email protected]>
Co-authored-by: arvenka <[email protected]>
Co-authored-by: Hari Prasad Perabattula <[email protected]>
Co-authored-by: Hari Prasad Perabattula <[email protected]>
Co-authored-by: tejasshah7 <[email protected]>
Co-authored-by: shnaya434 <[email protected]>
Co-authored-by: William Ehrich <[email protected]>
Co-authored-by: Will Ehrich <[email protected]>
Co-authored-by: litchiyangMSFT <[email protected]>
Co-authored-by: biaogao <[email protected]>
Co-authored-by: bhbhise <[email protected]>
Co-authored-by: mscorp-buchen <[email protected]>
Co-authored-by: Arpit Agarwal <[email protected]>
Co-authored-by: basharg <[email protected]>
Co-authored-by: Bashar Gharaibeh <[email protected]>
@ramya-rao-a
Copy link
Contributor

Code pointers for folks who would like to contribute a fix for this issue:

@github-actions GitHub Actions
Copy link

Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated Service Bus
Projects
Azure SDK for Service Bus
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xirzec @HarshaNalluru @ramya-rao-a