[KeyVault] - Include missing properties when reading SecretBundle #13614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sadasant
reviewed
Feb 5, 2021
| enabled: attributes?.enabled, | ||
| notBefore: attributes?.notBefore, | ||
| recoverableDays: attributes?.recoverableDays, | ||
| recoveryLevel: attributes?.recoveryLevel, |
There was a problem hiding this comment.
Woah! Thank you so much!
Before we had these transformers we used to use the spread operator a lot, and in my attempt to gain better control over it, I ended up missing these properties I think.
Should we see if we're having a similar issue in the other Key Vault clients?
There was a problem hiding this comment.
Good idea! Maybe we can merge this in and then I can separately check the other packages?
There was a problem hiding this comment.
Sounds good! I'll approve!
sadasant
reviewed
Feb 5, 2021
| import { DeletedSecretBundle, SecretBundle } from "../../src/generated"; | ||
| import { getSecretFromSecretBundle } from "../../src/transformations"; | ||
|
|
||
| describe("Transformations", () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
enabledwasn't being correctly set.