Added code to handle claims in authentication challenges #41814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcolin7
added
KeyVault
Client
vcolin7
requested review from
timovv,
chlowell,
JonathanCrd,
mccoyp,
gracewilcox and
gearama
|
API change check API changes are not detected in this pull request. |
6 tasks
JonathanCrd
reviewed
Sep 17, 2024
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Sep 17, 2024
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
…en is revoked immediately after acquiring it for the first time.
…all. Added async functionality for CAE.
mccoyp
reviewed
Sep 27, 2024
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Sep 30, 2024
...-secrets/src/test/java/com/azure/security/keyvault/secrets/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/azure/security/keyvault/secrets/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
...-secrets/src/test/java/com/azure/security/keyvault/secrets/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
…p if the client received multiple consecutive 401 unauthorized requests without claims.
alzimmermsft
reviewed
Oct 8, 2024
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
...java/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Oct 8, 2024
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Show resolved
Hide resolved
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
Unfortunately, we don't have a shared Key Vault package that we could put the policy into, and I don't feel that comfortable adding it onto Azure Core as is. Maybe I could come up with a better name for it and with some tweaks we can make it reusable for other cases (Tables uses a very similar authentication challenge system). |
timovv
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Oct 8, 2024
### Packages impacted by this PR - `@azure/keyvault-common` - Downstream Key Vault packages ### Issues associated with this PR - Private ### Describe the problem that is addressed by this PR In future, the Key Vault service will be adding support for Continuous Access Evaluation (CAE). This PR adds the necessary support to the SDK's challenge-based authentication policy to enable this feature. After the initial challenge, with CAE enabled, any future request may result in a 401 response, even if the access token used is valid. This PR adds a new policy that handles this CAE challenge alongside the normal challenge. The new policy replaces the existing use of Core's `bearerTokenAuthenticationPolicy`, which is no longer suitable for this use case since it cannot handle a CAE challenge that comes immediately after a regular challenge. ### Are there test cases added in this PR? _(If not, why?)_ Yes, added test cases with mock requests and responses to cover a number of different scenarios, ensuring the policy is doing the right thing. I also manually tested against a test resource provided by the Key Vault team which returns a CAE challenge in response to any authorized request to the vault, and got the expected result (a normal challenge handled successfully, followed by a CAE challenge handled successfully, followed by another CAE challenge which the policy does not handle). ### Provide a list of related PRs _(if any)_ - Java PR for same feature: Azure/azure-sdk-for-java#41814
chlowell
reviewed
Oct 9, 2024
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Show resolved
Hide resolved
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Oct 14, 2024
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
...n/src/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
Outdated
Show resolved
Hide resolved
chlowell
approved these changes
Oct 15, 2024
alzimmermsft
approved these changes
Oct 15, 2024
vcolin7
added a commit
that referenced
this pull request
Oct 15, 2024
vcolin7
added a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An access token can be revoked at any point by the service, after which the service will return a 401 Unauthorized response with a WWW-Authenticate header. This header will include claims for the client to decode and include in a subsequent auth request.
If everything goes right, the client will be provided a new and valid access token.