Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to handle claims in authentication challenges #41814

Merged
merged 19 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ private void createClient(HttpClient httpClient, SecretServiceVersion serviceVer
private void createClient(HttpClient httpClient, SecretServiceVersion serviceVersion, String testTenantId) {
secretClient = getClientBuilder(buildSyncAssertingClient(interceptorManager.isPlaybackMode()
? interceptorManager.getPlaybackClient() : httpClient), testTenantId, getEndpoint(), serviceVersion)
.disableChallengeResourceVerification()
.buildClient();

if (!interceptorManager.isLiveMode()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,10 @@ SecretClientBuilder getClientBuilder(HttpClient httpClient, String testTenantId,

if (interceptorManager.isLiveMode()) {
credential = new AzurePowerShellCredentialBuilder()
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.additionallyAllowedTenants("*")
.build();
} else if (interceptorManager.isRecordMode()) {
credential = new DefaultAzureCredentialBuilder()
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.additionallyAllowedTenants("*")
.build();
} else {
Expand All @@ -91,7 +89,6 @@ SecretClientBuilder getClientBuilder(HttpClient httpClient, String testTenantId,
}

SecretClientBuilder builder = new SecretClientBuilder()
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.vaultUrl(endpoint)
.serviceVersion(serviceVersion)
.credential(credential)
Expand Down
Loading