[keyvault] CAE support #31140
Merged
[keyvault] CAE support #31140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timovv
requested review from
vcolin7,
chlowell,
JonathanCrd,
mccoyp and
gracewilcox
timovv
force-pushed
the
keyvault/cae
branch
from
143fddf to
da5b147
Compare
chlowell
reviewed
Sep 17, 2024
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Sep 17, 2024
sdk/keyvault/keyvault-common/src/challengeBasedAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
…ms using a different order to the other test
chlowell
reviewed
Sep 17, 2024
sdk/keyvault/keyvault-common/src/challengeBasedAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
timovv
commented
Sep 24, 2024
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
timovv
commented
Sep 26, 2024
sdk/keyvault/keyvault-secrets/samples/v4/javascript/package.json
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Sep 30, 2024
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
maorleger
reviewed
Sep 30, 2024
sdk/keyvault/keyvault-common/src/challengeBasedAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Oct 2, 2024
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
chlowell
approved these changes
Oct 4, 2024
sdk/keyvault/keyvault-common/src/keyVaultAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/keyvault/keyvault-common/src/keyVaultAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/keyvault/keyvault-common/test/internal/challengeAuthenticationCallbacks.spec.ts
Outdated
Show resolved
Hide resolved
maorleger
approved these changes
Oct 8, 2024
sdk/keyvault/keyvault-common/src/keyVaultAuthenticationPolicy.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/keyvault-commonIssues associated with this PR
Describe the problem that is addressed by this PR
In future, the Key Vault service will be adding support for Continuous Access Evaluation (CAE). This PR adds the necessary support to the SDK's challenge-based authentication policy to enable this feature.
After the initial challenge, with CAE enabled, any future request may result in a 401 response, even if the access token used is valid. This PR adds a new policy that handles this CAE challenge alongside the normal challenge. The new policy replaces the existing use of Core's
bearerTokenAuthenticationPolicy, which is no longer suitable for this use case since it cannot handle a CAE challenge that comes immediately after a regular challenge.Are there test cases added in this PR? (If not, why?)
Yes, added test cases with mock requests and responses to cover a number of different scenarios, ensuring the policy is doing the right thing.
I also manually tested against a test resource provided by the Key Vault team which returns a CAE challenge in response to any authorized request to the vault, and got the expected result (a normal challenge handled successfully, followed by a CAE challenge handled successfully, followed by another CAE challenge which the policy does not handle).
Provide a list of related PRs (if any)