[CosmosDB] Migration support of existing containers/databases to autoscale #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing with remote
Syncing to remote
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can one of the admins verify this patch? |
azure-sdk-for-java - Release
|
azure-cli-extensions
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-trenton
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-net - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
This was referenced Apr 28, 2020
njuCZ
added
the
WaitForARMFeedback
MehaKaushik
approved these changes
Apr 30, 2020
Bring fork up-to-date
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@njuCZ Can you please review this change? |
Bringing fork up to date
[Staging] Swagger Validation Report
️✔️ |
| Rule | Message |
|---|---|
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-04-01/cosmos-db.json#L2942 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-04-01/cosmos-db.json#L2902 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L3283 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L3560 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L3600 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L3877 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L3917 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L4215 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L4258 |
|
The response is defined but without a default error response implementation.Consider adding it.' New: Microsoft.DocumentDB/stable/2020-03-01/cosmos-db.json#L4535 |
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
|
No commit pushedDate could be found for PR 9258 in repo Azure/azure-rest-api-specs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
this is not optimal design - modifying properties on a resource using POST action. Ideally it should be done via a PATCH/PUT operation. problems are - i) cant do from template ii) can break RBAC where caller doesnt have /write action on the resource but only /action permission for may be some other action. but now he is able to update properties of the resource via this action. |
|
We have made it clear that we would prefer a PUT based approach here but I don't think there is enough to warrant blocking this given the product teams adamant stance that POST is the way they want to go. |
pilor
added
ARMSignedOff
|
@ravgill Could you please have a look of the LintDiff CI error? It's labeled as |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@njuCZ adding the default response is creating a variety of Breaking changes, we are not comfortable with. We will add the default response in our next apiVersion, can we go ahead without it in this PR? |
|
@MehaKaushik, there are two definitions |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 3 commits
July 28, 2020 23:49
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yes. it is fine to have this default response in next new api version as it is a breaking change for existing stable version. |
njuCZ
approved these changes
Jul 30, 2020
iscai-msft
added a commit
to iscai-msft/azure-rest-api-specs
that referenced
this pull request
Oct 5, 2020
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits) Add preAttack tactic to swagger (Azure#10332) Add Url Signing action definition (Azure#10326) [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270) Add native blob soft delete (Azure#10308) Fix Microsoft.Resources naming issue (Azure#10318) Notebooks swagger spec (Azure#9841) Add network profile in Spring payload. (Azure#10313) Fix output-folder for go SDK in timeseriesinsight (Azure#10300) Alias Put Subscription API (Azure#10205) resource-resource-2019-03-01-python-config (Azure#10314) New Api version 2020-06-15- fixing certificate put/get issues with ARM (Azure#10251) [DataFactory] Support source sink level staging (Azure#10290) Added swagger files for PostgreSQL Flexible Server preview (Azure#10020) [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302) Adding Untracked Public Maintenance Config Resource Type (Azure#10281) add assignment resource id to the schema (Azure#10309) [datashare] sort api's and definitions (Azure#10273) Update readme.md all-api-versions tags (Azure#10296) Documentation updated (Azure#10283) [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258) ...
00Kai0
pushed a commit
to 00Kai0/azure-rest-api-specs
that referenced
this pull request
Oct 12, 2020
…scale (Azure#9258) * initial changes * update 2020-04-01 * update example * add default response * fixing ErrorResponse * updated the DefaultErrorResponse * Revert "updated the DefaultErrorResponse" This reverts commit 78c90b5. * Revert "fixing ErrorResponse" This reverts commit cab5d0f. * Revert "add default response" This reverts commit 18d8799. Co-authored-by: Meha Kaushik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.