-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added swagger files for PostgreSQL Flexible Server preview #10020
Conversation
[Staging] Swagger Validation Report
️✔️ |
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-java - Release
|
azure-sdk-for-net
|
azure-sdk-for-go - Release
|
azure-sdk-for-python
- Breaking Change detected in SDK
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradeepkintali few comments
...resource-manager/Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json
Outdated
Show resolved
Hide resolved
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/flexibleServers/{serverName}/updateConfigurations": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this API will not work. is updateConfigurations a resource type or an action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in PUT you must provide the instance name. if its singleton, please use "default" as the name. and so PUT.../configurations/default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOu can also support a PATCH to enable custoemrs to update the configurations.
} | ||
} | ||
}, | ||
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSql/flexibleServers/{serverName}/configurations/{configurationName}": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no PUT on this path? how are these configurations created?
...resource-manager/Microsoft.DBforPostgreSQL/preview/2020-02-14-privatepreview/postgresql.json
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
SIgning off from ARM side. |
…into fix_kv_python_readme * 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits) Add preAttack tactic to swagger (Azure#10332) Add Url Signing action definition (Azure#10326) [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270) Add native blob soft delete (Azure#10308) Fix Microsoft.Resources naming issue (Azure#10318) Notebooks swagger spec (Azure#9841) Add network profile in Spring payload. (Azure#10313) Fix output-folder for go SDK in timeseriesinsight (Azure#10300) Alias Put Subscription API (Azure#10205) resource-resource-2019-03-01-python-config (Azure#10314) New Api version 2020-06-15- fixing certificate put/get issues with ARM (Azure#10251) [DataFactory] Support source sink level staging (Azure#10290) Added swagger files for PostgreSQL Flexible Server preview (Azure#10020) [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302) Adding Untracked Public Maintenance Config Resource Type (Azure#10281) add assignment resource id to the schema (Azure#10309) [datashare] sort api's and definitions (Azure#10273) Update readme.md all-api-versions tags (Azure#10296) Documentation updated (Azure#10283) [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258) ...
* Initial swagger changes for SSPG. * Successfully validated the postgresql.json * Create different properties for Create and Update * Updated the Firewall rules api's. * Added Customer maintenance Window Get operation. * Added Delete operation for CMW * Added put API for CMW. * Added PITR API. * Fix for avocado and Spellcheck validations * Fixed the prettier check issues. * Fixed model validaiton error for Create * Fixed FirewallRuls_Create model validation * Fixed ConfigurationUpdate example json * Fixed Firewall Rules Get API * Fixed prettier issues for Configuration Update. * Fixed Update configuration schema * Fixed Create PITR server schema * Fixed semantic validations * Fixed Lint Diff errors * Removed next links * resolved code review comments * resolved code review comments * added the state properties * Fixed the server update example. * Resolved few code review comments * added pagination for all list operations. * Updated the CMW API Contracts. * rename from singleServers to flexibleServers * Updated cloud error body to common types. * Fixed lint errors. * Fixed the prettier * Revert "Fixed the prettier" This reverts commit 5140f06. * Revert "Fixed lint errors." This reverts commit fe54942. * Fixed new lint errors * state property name changes * Fixed the model validation errors * Fixed server list by resource group * publicIpAddressRequested to publicNetworkAccess * Added storage profile and Sku * Added Burstable as custom word. * Fix for R3020 PathResourceProviderNamePascalCase * Microsoft.DBForPostgreSQL to Microsoft.DBForPostgreSql * Fixed Lint errors R2016, R4010 * Fix for R2020 * Change names for Operation Ids. * Marked fields as readonly and LintDiff Error * Fixed model validation errors * Fixed lint diff * Fixed the Comments for Server object create * changed the put to post for update configurations * Removed the Confgiration Update for now
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.