Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Untracked Public Maintenance Config Resource Type #10281

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Adding Untracked Public Maintenance Config Resource Type #10281

merged 2 commits into from
Jul 31, 2020

Conversation

sotaneja
Copy link
Contributor

@sotaneja sotaneja commented Jul 28, 2020 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 28, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'SQLDB, SQLManagedInstance' from the old version.
New: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1495:9
Old: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1405:9
❌ 1020 - AddedEnumValue The new version is adding enum value(s) 'SQLDB, SQLManagedInstance' from the old version.
New: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1672:9
Old: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1568:9
❌ 1041 - AddedPropertyInResponse The new version has a new property 'visibility' in response that was not found in the old version.
New: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1483:7
Old: Microsoft.Maintenance/preview/2020-07-01-preview/Maintenance.json#L1393:7
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

azure-sdk-for-net - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 96a06e7 with merge commit 5699b02. SDK Automation 13.0.17.20200619.4
  • ️✔️azure-mgmt-maintenance [View full logs]  [Release SDK Changes] 
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-maintenance
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-maintenance
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 11.936% size of original (original: 14385 chars, delta: 1717 chars)
[ChangeLog] **Features**
[ChangeLog] 
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter duration
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter recur_every
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter visibility
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter time_zone
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter expiration_date_time
[ChangeLog]   - Model MaintenanceConfiguration has a new parameter start_date_time
[ChangeLog]   - Added operation group PublicMaintenanceConfigurationsOperations

@openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 28, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

azure-sdk-for-go - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

azure-sdk-for-java - Release

⌛ Pending...

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 28, 2020 •
edited
Loading

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 29, 2020
Closed
@ArcturusZhang
Copy link
Member

Approved breaking changes since the author claims

(API is not available yet so these are not breaking changes)

@ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 30, 2020
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 30, 2020
@ArcturusZhang ArcturusZhang merged commit 5699b02 into Azure:master Jul 31, 2020
@sotaneja sotaneja mentioned this pull request Jul 31, 2020
Merged
iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …
7d22d79 
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (29 commits)
  Add preAttack tactic to swagger (Azure#10332)
  Add Url Signing action definition (Azure#10326)
  [Synapse] Support long running operation and add subclass of Activity in artifact (Azure#10270)
  Add native blob soft delete (Azure#10308)
  Fix Microsoft.Resources naming issue (Azure#10318)
  Notebooks swagger spec (Azure#9841)
  Add network profile in Spring payload. (Azure#10313)
  Fix output-folder for go SDK in timeseriesinsight (Azure#10300)
  Alias Put Subscription API (Azure#10205)
  resource-resource-2019-03-01-python-config (Azure#10314)
  New Api version 2020-06-15- fixing certificate put/get issues with ARM  (Azure#10251)
  [DataFactory] Support source sink level staging (Azure#10290)
  Added swagger files for PostgreSQL Flexible Server preview (Azure#10020)
  [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview (Azure#10302)
  Adding Untracked Public Maintenance Config Resource Type (Azure#10281)
  add assignment resource id to the schema (Azure#10309)
  [datashare] sort api's and definitions (Azure#10273)
  Update readme.md all-api-versions tags (Azure#10296)
  Documentation updated (Azure#10283)
  [CosmosDB] Migration support of existing containers/databases to autoscale (Azure#9258)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@sotaneja @00Kai0
Adding Untracked Public Maintenance Config Resource Type (Azure#10281)
0d4fcc4 
* Adding Untracked Public Maintenance Config Resource Type

* Fixing linter checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees

@ArcturusZhang ArcturusZhang

Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sotaneja @azuresdkci @ArcturusZhang @ravbhatnagar