Add managed Vnet to stable version #25729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
AzureRestAPISpecReview
added
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
This was referenced Sep 8, 2023
This reverts commit f989c4c.
@ZhidaLiu Can someone please reply here to confirm the change in default is an intended change, matches service behavior, and is not an accidental breaking change accidentally introduced while fixing linter rules? |
TimLovellSmith
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
ZhidaLiu
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This is actually caused by default value removed introduced in the 2023-06-01-preview version instead of this stable version. |
...er/Microsoft.MachineLearningServices/stable/2023-10-01/examples/ManagedNetwork/listRule.json
Outdated
Show resolved
Hide resolved
| } | ||
| }, | ||
| "responses": { | ||
| "202": { |
There was a problem hiding this comment.
why doesn't create or update have an example 201 response? #Resolved
There was a problem hiding this comment.
Our service structure returns 202+ location header for all long-running operations. I don't think that's something we can change easily.
...rce-manager/Microsoft.MachineLearningServices/stable/2023-10-01/machineLearningServices.json
Show resolved
Hide resolved
| "ManagedNetwork" | ||
| ], | ||
| "operationId": "ManagedNetworkProvisions_ProvisionManagedNetwork", | ||
| "summary": "Provisions the managed network of a machine learning workspace.", |
There was a problem hiding this comment.
For purposes of reviewing the API - What does provision mean? Whats the difference betwen provisioning and creating? Does this create an ARM resource? #Resolved
There was a problem hiding this comment.
No, this API just starts a process to provision the managed network for the workspace resource type
There was a problem hiding this comment.
This API will provision some default sub-resources under the workspace based on info user provided, so the user doesn't have to know technical details and put all the information in the PUT request to make things work.
| "$ref": "#/definitions/OutboundRuleBasicResource" | ||
| } | ||
| }, | ||
| "202": { |
There was a problem hiding this comment.
201 + provisioningState is the recommended pattern for asynchronous resource creation. #Resolved
There was a problem hiding this comment.
For general info as to why provisioningState is preferred, refer to Microsoft API guidelines on long running operations.
There was a problem hiding this comment.
This will require a server-side structure change, will bring this up to my team but I don't think we can fix it in this version, will keep it as this together with other APIs.
There was a problem hiding this comment.
Will bring this to my team to discuss on this change, but for this version we will need to keep swagger align with the service behavior.
TimLovellSmith
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
ZhidaLiu
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
6 tasks
|
/pr RequestMerge |
visingla-ms
approved these changes
Sep 19, 2023
visingla-ms
merged commit 2a2c6b0
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01
kseager
pushed a commit
to kseager/azure-rest-api-specs
that referenced
this pull request
Oct 4, 2023
* Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples
kseager
pushed a commit
to kseager/azure-rest-api-specs
that referenced
this pull request
Oct 6, 2023
* Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples
rkmanda
pushed a commit
that referenced
this pull request
Oct 16, 2023
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.