Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Release machinelearningservices microsoft.machine learning services 2023 10 01 #24949

Conversation

kseager
Copy link
Contributor

@kseager kseager commented Jul 24, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 24, 2023

Swagger pipeline can not start as the pull request has merge conflicts.

@openapi-workflow-bot
Copy link

Hi, @kseager! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 24, 2023

    Swagger pipeline can not start as the pull request has merge conflicts.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 24, 2023

    Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

    @openapi-workflow-bot
    Copy link

    Hi @kseager! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    @AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Aug 4, 2023
    @openapi-workflow-bot
    Copy link

    Hi @kseager! The automation detected breaking changes in this pull request. As a result, it added the BreakingChangeReviewRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Fix the breaking change.
    Please consult the documentation provided in the relevant validation failures.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot fix the breaking changes, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 23, 2023

    Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

    shail2208 and others added 2 commits August 28, 2023 10:42
    Co-authored-by: Shail Paragbhai Shah <[email protected]>
    * Try fixing some lint error
    
    * bug fix
    
    * remove unused definition
    
    * Update Example
    @kseager kseager marked this pull request as ready for review September 11, 2023 14:53
    @kseager
    Copy link
    Contributor Author

    kseager commented Sep 19, 2023

        }
    

    Please respond to this.

    In reply to: 1716633059

    Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json:9578 in 5fb8294. [](commit_id = 5fb8294, deletion_comment = False)

    As I have mentioned before, all of these changes are either legacy or pre-reviewed/approved and are team specific. This PR is just to add them in as a unit.

    ZhidaLiu and others added 3 commits September 19, 2023 17:48
    * Add managed Vnet to stable version
    
    * update missing parameter
    
    * Update missing ref
    
    * meaningless commit trigger pipeline again
    
    * Revert "meaningless commit trigger pipeline again"
    
    This reverts commit baa386b.
    
    * add missing ref
    
    * Update example version
    
    * trigger pipeline
    
    * Revert "trigger pipeline"
    
    This reverts commit f989c4c.
    
    * add force to purge parameter
    
    * trigger pipeline
    
    * Revert "trigger pipeline"
    
    This reverts commit 42ea0f8.
    
    * Update examples
    
    * Add format and update examples
    * Add model monitoring scenarios
    
    * add
    
    * add
    
    * Update mfe.json
    
    * Update mfe.json
    
    * Update mfe.json
    
    * Update mfe.json
    Co-authored-by: Aaheli Chattopadhyay <[email protected]>
    @kseager
    Copy link
    Contributor Author

    kseager commented Sep 21, 2023

    Please fix circular references as mentioned in other swagger PR also.

    I have this PR's which is approved and will be merged soon: #25879
    to fix this request

    @kseager kseager removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Sep 21, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 21, 2023
    * TriggerType->ComputeTriggerType
    
    * RecurrenceFrequency->ComputeRecurrenceFrequency
    
    * RecurrenceSchedule->ComputeRecurrenceSchedule
    
    * description
    
    ---------
    
    Co-authored-by: Kayla Ames <[email protected]>
    @visingla-ms visingla-ms added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 22, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 22, 2023
    shail2208 and others added 2 commits September 22, 2023 10:54
    Co-authored-by: Shail Paragbhai Shah <[email protected]>
    * Add examples
    
    * Adding feature store GA api's
    
    * Sync examples
    
    * Add examples
    
    * Converting to ProxyResource
    
    ---------
    
    Co-authored-by: Shail Paragbhai Shah <[email protected]>
    Co-authored-by: Aaheli Chattopadhyay <[email protected]>
    @kseager
    Copy link
    Contributor Author

    kseager commented Oct 4, 2023

    /pr RequestMerge

    @kseager
    Copy link
    Contributor Author

    kseager commented Oct 4, 2023

    merge conflict #26085

    Co-authored-by: Kayla Ames <[email protected]>
    @kseager
    Copy link
    Contributor Author

    kseager commented Oct 6, 2023

    updating main instead #26106

    @kseager kseager changed the title Release machinelearningservices microsoft.machine learning services 2023 10 01 [Hub Generated] Release machinelearningservices microsoft.machine learning services 2023 10 01 Oct 6, 2023
    @ms-zhenhua
    Copy link
    Contributor

    please resolve the branch conflict and then run /pr RequestMerge to request merge

    …26121)
    
    * Add workspace kind and featureStoreSettings
    
    * add description
    
    * Add description for ComputeRuntimeDti
    
    * remove featurestore settings for lint
    
    * remove Kind
    
    * Revert "remove featurestore settings for lint"
    
    This reverts commit f4d7ae3.
    
    * Update readme
    
    fix
    @kseager
    Copy link
    Contributor Author

    kseager commented Oct 13, 2023

    will merge this PR through proxy/shadow: #26104

    @kseager kseager closed this Oct 13, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-MissingBaseCommit new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.