-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed Vnet to stable version #25729
Merged
visingla-ms
merged 14 commits into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01
from
ZhidaLiu:user/zhili/wrp-2023-10-01
Sep 19, 2023
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c6346df
Add managed Vnet to stable version
ZhidaLiu 54b153f
update missing parameter
ZhidaLiu 01f0f72
Update missing ref
ZhidaLiu baa386b
meaningless commit trigger pipeline again
ZhidaLiu 1540c94
Revert "meaningless commit trigger pipeline again"
ZhidaLiu f21b6b5
add missing ref
ZhidaLiu 1527274
Update example version
ZhidaLiu f989c4c
trigger pipeline
ZhidaLiu f250f56
Revert "trigger pipeline"
ZhidaLiu 1e4b862
add force to purge parameter
ZhidaLiu 42ea0f8
trigger pipeline
ZhidaLiu 56d0afc
Revert "trigger pipeline"
ZhidaLiu 475a012
Update examples
ZhidaLiu eb58842
Add format and update examples
ZhidaLiu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
...MachineLearningServices/stable/2023-10-01/examples/ManagedNetwork/createOrUpdateRule.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "test-rg", | ||
| "workspaceName": "aml-workspace-name", | ||
| "ruleName": "rule_name_1", | ||
| "api-version": "2023-10-01", | ||
| "body": { | ||
| "properties": { | ||
| "type": "FQDN", | ||
| "destination": "destination_endpoint", | ||
| "status": "Active", | ||
| "category": "UserDefined" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "example_location" | ||
| } | ||
| }, | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/test-rg/providers/Microsoft.MachineLearningServices/workspaces/aml-workspace-name/outboundRules/rule_name_1", | ||
| "name": "rule_name_1", | ||
| "type": "workspace/outboundRules", | ||
| "properties": { | ||
| "type": "FQDN", | ||
| "destination": "destination_endpoint", | ||
| "status": "Active", | ||
| "category": "UserDefined" | ||
| } | ||
| } | ||
ZhidaLiu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
18 changes: 18 additions & 0 deletions
18
...crosoft.MachineLearningServices/stable/2023-10-01/examples/ManagedNetwork/deleteRule.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "test-rg", | ||
| "workspaceName": "aml-workspace-name", | ||
| "ruleName": "rule-name", | ||
| "api-version": "2023-10-01" | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "location_url_to_poll_for_status" | ||
| } | ||
| }, | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
.../Microsoft.MachineLearningServices/stable/2023-10-01/examples/ManagedNetwork/getRule.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "test-rg", | ||
| "workspaceName": "aml-workspace-name", | ||
| "ruleName": "name_of_the_fqdn_rule", | ||
| "api-version": "2023-10-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/test-rg/providers/Microsoft.MachineLearningServices/workspaces/aml-workspace-name/outboundRules/rule_name_1", | ||
| "name": "rule_name_1", | ||
| "type": "workspace/outboundRules", | ||
| "properties": { | ||
| "type": "FQDN", | ||
| "destination": "destination_of_the_fqdn_rule", | ||
| "status": "Active", | ||
| "category": "UserDefined" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
39 changes: 39 additions & 0 deletions
39
...Microsoft.MachineLearningServices/stable/2023-10-01/examples/ManagedNetwork/listRule.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "test-rg", | ||
| "workspaceName": "aml-workspace-name", | ||
| "api-version": "2023-10-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/test-rg/providers/Microsoft.MachineLearningServices/workspaces/aml-workspace-name/outboundRules/rule_name_1", | ||
| "name": "rule_name_1", | ||
| "type": "workspace/outboundRules", | ||
| "properties": { | ||
| "type": "FQDN", | ||
| "destination": "destination_of_the_fqdn_rule", | ||
| "status": "Inactive", | ||
| "category": "Required" | ||
| } | ||
| }, | ||
| { | ||
| "id": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/test-rg/providers/Microsoft.MachineLearningServices/workspaces/aml-workspace-name/outboundRules/rule_name_2", | ||
| "name": "rule_name_2", | ||
| "type": "workspace/outboundRules", | ||
| "properties": { | ||
| "type": "FQDN", | ||
| "destination": "destination_of_the_fqdn_rule", | ||
| "status": "Inactive", | ||
| "category": "Required" | ||
ZhidaLiu marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
24 changes: 24 additions & 0 deletions
24
...icrosoft.MachineLearningServices/stable/2023-10-01/examples/ManagedNetwork/provision.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "00000000-1111-2222-3333-444444444444", | ||
| "resourceGroupName": "test-rg", | ||
| "workspaceName": "aml-workspace-name", | ||
| "api-version": "2023-10-01", | ||
| "body": { | ||
| "includeSpark": false | ||
| } | ||
| }, | ||
| "responses": { | ||
| "202": { | ||
| "headers": { | ||
| "Location": "location_url_to_poll_for_status" | ||
| } | ||
| }, | ||
| "200": { | ||
| "body": { | ||
| "status": "Active", | ||
| "sparkReady": true | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why doesn't create or update have an example 201 response? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our service structure returns 202+ location header for all long-running operations. I don't think that's something we can change easily.