Fixing issues with a few breaking changes #23943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jeremyfrosti Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| DatabaseExtensions.json | 2022-11-01-preview(a7a5df2) | 2021-11-01(main) |
| DatabaseExtensions.json | 2022-11-01-preview(a7a5df2) | 2022-08-01-preview(main) |
| ManagedDatabases.json | 2022-11-01-preview(a7a5df2) | 2021-11-01(main) |
| ManagedDatabases.json | 2022-11-01-preview(a7a5df2) | 2022-08-01-preview(main) |
| Servers.json | 2022-11-01-preview(a7a5df2) | 2021-11-01(main) |
| Servers.json | 2022-11-01-preview(a7a5df2) | 2022-08-01-preview(main) |
| SyncAgents.json | 2022-11-01-preview(a7a5df2) | 2021-11-01(main) |
| SyncAgents.json | 2022-11-01-preview(a7a5df2) | 2022-08-01-preview(main) |
| SyncGroups.json | 2022-11-01-preview(a7a5df2) | 2021-11-01(main) |
| SyncGroups.json | 2022-11-01-preview(a7a5df2) | 2022-08-01-preview(main) |
| SyncMembers.json | 2022-11-01-preview(a7a5df2) | 2021-11-01(main) |
| SyncMembers.json | 2022-11-01-preview(a7a5df2) | 2022-08-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
The new version has a different x-ms-enum 'name' than the previous one. New: Microsoft.Sql/preview/2022-11-01-preview/Servers.json#L1034:9 Old: Microsoft.Sql/stable/2021-11-01/Servers.json#L935:9 |
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.2) | new version | base version |
|---|---|---|
| package-preview-2022-11 | package-preview-2022-11(a7a5df2) | package-preview-2022-11(release-sql-Microsoft.Sql-2022-11-01-preview) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'serverName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L19 |
|
The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L19 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L50 |
|
/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Sql/servers/{serverName}/databases/{databaseName}/extensions/{extensionName} has different responses for PUT/GET/PATCH operations. The PUT/GET/PATCH operations must have same schema response. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L64 |
|
The resource name parameter 'serverName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L64 |
|
The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L64 |
|
The resource name parameter 'extensionName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L64 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L98 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L108 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L108 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'DatabaseExtensions_CreateOrUpdate' Request Model: 'parameters[4].schema' Response Model: 'responses[200].schema' Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L108 |
|
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L146 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L153 |
|
A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L156 |
|
The nested resource 'ImportExportExtensionsOperationResult' does not have list operation, please add it. Location: Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json#L318 |
|
The resource name parameter 'managedInstanceName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L19 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L47 |
|
The resource name parameter 'managedInstanceName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L61 |
|
The resource name parameter 'databaseName' should be defined with a 'pattern' restriction. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L61 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L92 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L102 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L102 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L141 |
|
A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L144 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L185 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L212 |
|
A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L215 |
|
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L262 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L268 |
|
A 202 response should include an Location response header. Location: Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json#L271 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
ghost
added
the
Swagger Generation Artifacts
|
Generated ApiView
|
jeremyfrosti
changed the title
ericshape
approved these changes
May 11, 2023
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @jeremyfrosti, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @jeremyfrosti, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
@mikekistler Please help review the breaking change in this PR. |
|
@mikekistler Please help review the breaking change in this PR. Thanks a lot. |
JeffreyRichter
added
the
Approved-BreakingChange
|
@jeremyfrosti Please fix CI checks errors ( |
|
@jeremyfrosti , can you work on the |
|
@chidozieononiwu Please help review the |
Failing due to the below error: But it's not introduced in this PR, we can ignore it for now, will need to handle it while generating .NET SDK. |
raych1
added
the
Approved-SdkBreakingChange-Go
|
@qiaozha Please help review JS breaking change. |
|
@chidozieononiwu, @maririos Please help review the |
v-xuto
approved these changes
May 18, 2023
v-xuto
added
the
Approved-OkToMerge
raych1
pushed a commit
that referenced
this pull request
May 19, 2023
* Adds base for updating Microsoft.Sql from version preview/2022-08-01-preview to version 2022-11-01-preview * Updates readme * Updates API version in new specs and examples * Add Swagger API changes required for progress-reporting related changes in DatabaseOperations (#22669) * Update swagger (#22715) * Follow-up Swagger API changes required for progress-reporting related changes in DatabaseOperations (#22775) * Add Swagger API changes required for progress-reporting related changes in DatabaseOperations * Follow up changes required for progress-reporting related changes in DatabaseOperations * updated example file * Added Failed case in list-operations examples * Update Microsoft.Sql ManagedInstance 2022-11-01-preview Swagger Docs (#22899) * Update Microsoft.sql ManagedInstance 2022-11-01-preview Swagger Docs * Address Swagger Validation Errors * Modify custom-words.txt * Manually updating arm-id format to match stable 2021-11-01 version * Adding provisioning state changes * fixing validation * adding missing space * Remove HTTP 200 from Start/Stop Actions as we only return HTTP 202 --------- Co-authored-by: Jovana Toroman <[email protected]> * Update DateTime to ISO-8601 format in example file (#22986) * Add Swagger API changes required for progress-reporting related changes in DatabaseOperations * Follow up changes required for progress-reporting related changes in DatabaseOperations * updated example file * Added Failed case in list-operations examples * Update DateTime to ISo-8601 format in example file * Enable TryPlannedBeforeForcedFailover for SQL DB Failover Group (#22673) * Enable TryPlannedBeforeForcedFailover for SQL DB Failover Group * Modify example file * Add example * Fix ModelValidation issues * Fix ModelValidation issues * Add new controller * Modify example * Modify example * Update server name * Fix LintDiff * Fix model validation errors * Fix PostOperationAsyncResponseValidation, Unfix LroLocationHeader,ResourceNameRestriction * Fix PostOperationAsyncResponseValidation * Fix pending items * Update doc * Remove empty/unschematized object --------- Co-authored-by: subhrob <[email protected]> * [DO NOT MERGE] Add Archive option to LTR Policy for SQL DB (#22697) * add archival changes to LTRPolicy * fix LongTermRetentionPolicies swagger file * fix check failures * redo swagger * Update swagger documentation for Managed Instance start-stop actions (#22992) * Add NetworkSecurityPerimeterConfigurations Swagger (#22960) * Add NetworkSecurityPerimeterConfigurations Swagger * Fixes round 1 * Fixes round 2 * Fixes Round 3 * Fixes Round 4 * Fix Round 5 * fixing enum (#22995) Co-authored-by: Jovana Toroman <[email protected]> * add changes (#23120) * Carry all minor changes to dev sql microsoft.sql 2022 11 01 preview (#23337) * Revert "add changes (#23120)" This reverts commit 5c348d2. Revert "[DO NOT MERGE] Add Archive option to LTR Policy for SQL DB (#22697)" This reverts commit 559f7f4. * Carrying minor changes to release branch for Microsoft.Sql 2022-11-01-preview * Reverting DatabaseAdvisors * Further reverting problematic files * Reverting a few example files * Adding back arm-id to a few files * Reverting error message change in ManagedDatabaseRestoreDetails.json, Jobs.json,ServerDevOpsAudit.json, and TransparentDataEncryptions.json * Minor fixes for Turkey name change and missing x-ms-identifier (#23637) * Fixing issues with a few breaking changes (#23943) * Minor fixes for Turkey name change and missing x-ms-identifier * Adding back missing arm-id and other missing property issues causing breaking changes incorrectly. * Fixing prettier issue with ManagedDatabases.json * Fixing arm-id format in 4 examples * Adding missing location for 202 responses on sync examples --------- Co-authored-by: Ji Wang <[email protected]> Co-authored-by: Mohit Agarwal <[email protected]> Co-authored-by: GalGoldi72 <[email protected]> Co-authored-by: ilijadivljan-ms <[email protected]> Co-authored-by: Jovana Toroman <[email protected]> Co-authored-by: subhrob <[email protected]> Co-authored-by: subhrob <[email protected]> Co-authored-by: CelinaJiangJXY <[email protected]> Co-authored-by: beoberha <[email protected]> Co-authored-by: toki95 <[email protected]>
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
A couple of these were handled in the previous PR: #23637
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.