Fixing issues with a few breaking changes (#23943)

* Minor fixes for Turkey name change and missing x-ms-identifier * Adding back missing arm-id and other missing property issues causing breaking changes incorrectly. * Fixing prettier issue with ManagedDatabases.json * Fixing arm-id format in 4 examples * Adding missing location for 202 responses on sync examples
Azure · May 18, 2023 · 465891a · 465891a
1 parent ee86d4a
commit 465891a
Show file tree

Hide file tree

Showing 17 changed files with 78 additions and 19 deletions.
diff --git a/...ion/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json b/...ion/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json
@@ -399,13 +399,15 @@
         "storageAccountResourceId": {
           "description": "The resource id for the storage account used to store BACPAC file. If set, private endpoint connection will be created for the storage account. Must match storage account used for StorageUri parameter.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
         },
         "sqlServerResourceId": {
           "description": "The resource id for the SQL server which is the target of this request. If set, private endpoint connection will be created for the SQL server. Must match server which is target of the operation.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]

diff --git a/...ation/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json b/...ation/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json
@@ -598,7 +598,8 @@
       "properties": {
         "destinationManagedDatabaseId": {
           "description": "The destination managed database ID",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id"
         }
       }
     },
@@ -706,27 +707,31 @@
         "sourceDatabaseId": {
           "description": "The resource identifier of the source database associated with create operation of this database.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
         },
         "crossSubscriptionSourceDatabaseId": {
           "description": "The resource identifier of the cross-subscription source database associated with create operation of this database.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
         },
         "restorableDroppedDatabaseId": {
           "description": "The restorable dropped database resource id to restore when creating this database.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
         },
         "crossSubscriptionRestorableDroppedDatabaseId": {
           "description": "The restorable cross-subscription dropped database resource id to restore when creating this database.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
@@ -753,13 +758,15 @@
         "recoverableDatabaseId": {
           "description": "The resource identifier of the recoverable database associated with create operation of this database.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
         },
         "longTermRetentionBackupResourceId": {
           "description": "The name of the Long Term Retention backup to be used for restore of this managed database.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
@@ -804,7 +811,8 @@
       "properties": {
         "destinationManagedDatabaseId": {
           "description": "The destination managed database ID",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id"
         },
         "operationMode": {
           "description": "The move operation mode.",

diff --git a/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/Servers.json b/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/Servers.json
@@ -697,13 +697,15 @@
         "storageAccountResourceId": {
           "description": "The resource id for the storage account used to store BACPAC file. If set, private endpoint connection will be created for the storage account. Must match storage account used for StorageUri parameter.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
         },
         "sqlServerResourceId": {
           "description": "The resource id for the SQL server which is the target of this request. If set, private endpoint connection will be created for the SQL server. Must match server which is target of the operation.",
           "type": "string",
+          "format": "arm-id",
           "x-ms-mutability": [
             "create"
           ]
@@ -1026,7 +1028,7 @@
           "readOnly": true
         },
         "minimalTlsVersion": {
-          "description": "Minimal TLS version. Allowed values: '1.0', '1.1', '1.2'",
+          "description": "Minimal TLS version. Allowed values: 'None', '1.0', '1.1', '1.2'",
           "type": "string"
         },
         "publicNetworkAccess": {
@@ -1057,7 +1059,15 @@
         },
         "primaryUserAssignedIdentityId": {
           "description": "The resource id of a user assigned identity to be used by default.",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id",
+          "x-ms-arm-id-details": {
+            "allowedResources": [
+              {
+                "type": "Microsoft.ManagedIdentity/userAssignedIdentities"
+              }
+            ]
+          }
         },
         "federatedClientId": {
           "format": "uuid",

diff --git a/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncAgents.json b/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncAgents.json
@@ -475,7 +475,8 @@
         },
         "syncDatabaseId": {
           "description": "ARM resource id of the sync database in the sync agent.",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id"
         },
         "lastAliveTime": {
           "format": "date-time",

diff --git a/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncGroups.json b/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncGroups.json
@@ -938,7 +938,8 @@
         },
         "syncDatabaseId": {
           "description": "ARM resource id of the sync database in the sync group.",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id"
         },
         "hubDatabaseUserName": {
           "description": "User name for the sync group hub database credential.",

diff --git a/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncMembers.json b/specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncMembers.json
@@ -638,7 +638,15 @@
         },
         "syncAgentId": {
           "description": "ARM resource id of the sync agent in the sync member.",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id",
+          "x-ms-arm-id-details": {
+            "allowedResources": [
+              {
+                "type": "Microsoft.Sql/servers/syncAgents"
+              }
+            ]
+          }
         },
         "sqlServerDatabaseId": {
           "format": "uuid",
@@ -647,7 +655,8 @@
         },
         "syncMemberAzureDatabaseResourceId": {
           "description": "ARM resource id of the sync member logical database, for sync members in Azure.",
-          "type": "string"
+          "type": "string",
+          "format": "arm-id"
         },
         "usePrivateLinkConnection": {
           "description": "Whether to use private link connection.",

diff --git a/...-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseCancelMove.json b/...-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseCancelMove.json
@@ -6,7 +6,7 @@
     "databaseName": "testDatabase",
     "api-version": "2022-11-01-preview",
     "parameters": {
-      "destinationManagedDatabaseId": "subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase"
+      "destinationManagedDatabaseId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase"
     }
   },
   "responses": {

diff --git a/...anager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseCompleteMove.json b/...anager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseCompleteMove.json
@@ -6,7 +6,7 @@
     "databaseName": "testDatabase",
     "api-version": "2022-11-01-preview",
     "parameters": {
-      "destinationManagedDatabaseId": "subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase"
+      "destinationManagedDatabaseId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase"
     }
   },
   "responses": {

diff --git a/...anager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseStartMoveMax.json b/...anager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseStartMoveMax.json
@@ -6,7 +6,7 @@
     "databaseName": "testDatabase",
     "api-version": "2022-11-01-preview",
     "parameters": {
-      "destinationManagedDatabaseId": "subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase",
+      "destinationManagedDatabaseId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase",
       "operationMode": "Copy"
     }
   },

diff --git a/...anager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseStartMoveMin.json b/...anager/Microsoft.Sql/preview/2022-11-01-preview/examples/ManagedDatabaseStartMoveMin.json
@@ -6,7 +6,7 @@
     "databaseName": "testDatabase",
     "api-version": "2022-11-01-preview",
     "parameters": {
-      "destinationManagedDatabaseId": "subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase"
+      "destinationManagedDatabaseId": "/subscriptions/00000000-1111-2222-3333-444444444444/resourceGroups/group1/providers/Microsoft.Sql/managedInstances/testInstanceTgt/databases/testDatabase"
     }
   },
   "responses": {

diff --git a/...l/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncAgentDelete.json b/...l/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncAgentDelete.json
@@ -8,7 +8,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...l/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncGroupDelete.json b/...l/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncGroupDelete.json
@@ -9,7 +9,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...ql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncGroupPatch.json b/...ql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncGroupPatch.json
@@ -35,6 +35,10 @@
         "type": "Microsoft.Sql/servers/databases/syncGroups"
       }
     },
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    }
   }
 }
diff --git a/...-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncGroupRefreshHubSchema.json b/...-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncGroupRefreshHubSchema.json
@@ -9,6 +9,10 @@
   },
   "responses": {
     "200": {},
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    }
   }
 }
diff --git a/.../resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncMemberDelete.json b/.../resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncMemberDelete.json
@@ -10,7 +10,11 @@
   },
   "responses": {
     "200": {},
-    "202": {},
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    },
     "204": {}
   }
 }
diff --git a/...l/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncMemberPatch.json b/...l/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncMemberPatch.json
@@ -38,6 +38,10 @@
         "type": "Microsoft.Sql/servers/databases/syncGroups/syncMembers"
       }
     },
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    }
   }
 }
diff --git a/...ce-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncMemberRefreshSchema.json b/...ce-manager/Microsoft.Sql/preview/2022-11-01-preview/examples/SyncMemberRefreshSchema.json
@@ -10,6 +10,10 @@
   },
   "responses": {
     "200": {},
-    "202": {}
+    "202": {
+      "headers": {
+        "Location": "https://management.azure.com/subscriptions/00000000-1111-2222-3333-444444444444/providers/Microsoft.Sql/locations/westus/operation/00000000-1111-2222-3333-444444444444?api-version=2022-11-01-preview"
+      }
+    }
   }
 }