Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues with a few breaking changes #23943

Merged
merged 5 commits into from
May 18, 2023
Merged

Fixing issues with a few breaking changes #23943

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0205b3
Minor fixes for Turkey name change and missing x-ms-identifier
jeremyfrosti Apr 19, 2023
34b90cc
Adding back missing arm-id and other missing property issues causing …
jeremyfrosti May 11, 2023
e66a94b
Fixing prettier issue with ManagedDatabases.json
jeremyfrosti May 12, 2023
24835a9
Fixing arm-id format in 4 examples
jeremyfrosti May 16, 2023
a7a5df2
Adding missing location for 202 responses on sync examples
jeremyfrosti May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ion/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/DatabaseExtensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,13 +399,15 @@
"storageAccountResourceId": {
"description": "The resource id for the storage account used to store BACPAC file. If set, private endpoint connection will be created for the storage account. Must match storage account used for StorageUri parameter.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
},
"sqlServerResourceId": {
"description": "The resource id for the SQL server which is the target of this request. If set, private endpoint connection will be created for the SQL server. Must match server which is target of the operation.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
Expand Down
3 changes: 2 additions & 1 deletion ...icrosoft.Sql/preview/2022-11-01-preview/DatabaseVulnerabilityAssessmentRuleBaselines.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@
"type": "array",
"items": {
"$ref": "#/definitions/DatabaseVulnerabilityAssessmentRuleBaselineItem"
}
},
"x-ms-identifier": []
}
}
}
Expand Down
12 changes: 10 additions & 2 deletions ...ation/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/ManagedDatabases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,8 @@
"properties": {
"destinationManagedDatabaseId": {
"description": "The destination managed database ID",
"type": "string"
"type": "string",
"format": "arm-id"
}
}
},
Expand Down Expand Up @@ -706,27 +707,31 @@
"sourceDatabaseId": {
"description": "The resource identifier of the source database associated with create operation of this database.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
},
"crossSubscriptionSourceDatabaseId": {
"description": "The resource identifier of the cross-subscription source database associated with create operation of this database.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
},
"restorableDroppedDatabaseId": {
"description": "The restorable dropped database resource id to restore when creating this database.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
},
"crossSubscriptionRestorableDroppedDatabaseId": {
"description": "The restorable cross-subscription dropped database resource id to restore when creating this database.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
Expand All @@ -753,13 +758,15 @@
"recoverableDatabaseId": {
"description": "The resource identifier of the recoverable database associated with create operation of this database.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
},
"longTermRetentionBackupResourceId": {
"description": "The name of the Long Term Retention backup to be used for restore of this managed database.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
Expand Down Expand Up @@ -804,7 +811,8 @@
"properties": {
"destinationManagedDatabaseId": {
"description": "The destination managed database ID",
"type": "string"
"type": "string",
"format": "arm-id"
},
"operationMode": {
"description": "The move operation mode.",
Expand Down
14 changes: 12 additions & 2 deletions specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/Servers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,13 +697,15 @@
"storageAccountResourceId": {
"description": "The resource id for the storage account used to store BACPAC file. If set, private endpoint connection will be created for the storage account. Must match storage account used for StorageUri parameter.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
},
"sqlServerResourceId": {
"description": "The resource id for the SQL server which is the target of this request. If set, private endpoint connection will be created for the SQL server. Must match server which is target of the operation.",
"type": "string",
"format": "arm-id",
"x-ms-mutability": [
"create"
]
Expand Down Expand Up @@ -1026,7 +1028,7 @@
"readOnly": true
},
"minimalTlsVersion": {
"description": "Minimal TLS version. Allowed values: '1.0', '1.1', '1.2'",
"description": "Minimal TLS version. Allowed values: 'None', '1.0', '1.1', '1.2'",
"type": "string"
},
"publicNetworkAccess": {
Expand Down Expand Up @@ -1057,7 +1059,15 @@
},
"primaryUserAssignedIdentityId": {
"description": "The resource id of a user assigned identity to be used by default.",
"type": "string"
"type": "string",
"format": "arm-id",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.ManagedIdentity/userAssignedIdentities"
}
]
}
},
"federatedClientId": {
"format": "uuid",
Expand Down
3 changes: 2 additions & 1 deletion specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncAgents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,8 @@
},
"syncDatabaseId": {
"description": "ARM resource id of the sync database in the sync agent.",
"type": "string"
"type": "string",
"format": "arm-id"
},
"lastAliveTime": {
"format": "date-time",
Expand Down
3 changes: 2 additions & 1 deletion specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncGroups.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,8 @@
},
"syncDatabaseId": {
"description": "ARM resource id of the sync database in the sync group.",
"type": "string"
"type": "string",
"format": "arm-id"
},
"hubDatabaseUserName": {
"description": "User name for the sync group hub database credential.",
Expand Down
13 changes: 11 additions & 2 deletions specification/sql/resource-manager/Microsoft.Sql/preview/2022-11-01-preview/SyncMembers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,15 @@
},
"syncAgentId": {
"description": "ARM resource id of the sync agent in the sync member.",
"type": "string"
"type": "string",
"format": "arm-id",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.Sql/servers/syncAgents"
}
]
}
},
"sqlServerDatabaseId": {
"format": "uuid",
Expand All @@ -647,7 +655,8 @@
},
"syncMemberAzureDatabaseResourceId": {
"description": "ARM resource id of the sync member logical database, for sync members in Azure.",
"type": "string"
"type": "string",
"format": "arm-id"
},
"usePrivateLinkConnection": {
"description": "Whether to use private link connection.",
Expand Down
6 changes: 3 additions & 3 deletions ...rosoft.Sql/preview/2022-11-01-preview/examples/ManagedInstanceTimeZoneListByLocation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,11 +1054,11 @@
},
{
"properties": {
"timeZoneId": "Turkey Standard Time",
"timeZoneId": "Türkiye Standard Time",
"displayName": "(UTC+03:00) Istanbul"
},
"id": "/subscriptions/37d5e605-6142-4d79-b564-28b6dbfeec0f/providers/Microsoft.Sql/locations/onebox/timeZones/Turkey Standard Time",
"name": "Turkey Standard Time",
"id": "/subscriptions/37d5e605-6142-4d79-b564-28b6dbfeec0f/providers/Microsoft.Sql/locations/onebox/timeZones/Türkiye Standard Time",
"name": "Türkiye Standard Time",
"type": "Microsoft.Sql/locations/timeZones"
},
{
Expand Down