[Compute] Revert Generate-SSH file permission changes because of Cloudshell failure #23477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haagha
requested review from
bilaakpan-ms,
Sandido and
grizzlytheodore
as code owners
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Compute
️✔️Az.EventHub
️✔️Az.KeyVault
️✔️Az.ManagedServiceIdentity
️✔️Az.Monitor
️✔️Az.Network
️✔️Az.OperationalInsights
️✔️Az.PrivateDns
️✔️Az.RecoveryServices
️✔️Az.Security
️✔️Az.Sql
️✔️Az.Ssh
️✔️Az.Storage
|
Sandido
requested changes
Nov 27, 2023
Sandido
approved these changes
Nov 28, 2023
NoriZC
added a commit
that referenced
this pull request
Nov 29, 2023
…dshell failure (#23477) * reverting changes for file permissions of private key using New-Azvm * Update ChangeLog.md --------- Co-authored-by: NoriZC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting Commit d229798
In this PR I introduced reduced permissions for private key when using Generate SSH parameter using Access Control API. This API turned out to be platform dependent Library and did not work for Linux and hence broke the Generate SSH parameter in Cloudshell. Reverting these changes.
Currently introducing failures for live customers that are using New-Azvm with -GenerateSSH in cloudshell so please review and merge.
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.