Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compute] VirtualMachineScaleSetId Parameter for Update-Azvm and Reduced File permissions for SSH key #23170

Merged
merged 14 commits into from
Nov 8, 2023
Merged

[Compute] VirtualMachineScaleSetId Parameter for Update-Azvm and Reduced File permissions for SSH key #23170

merged 14 commits into from
Nov 8, 2023

Conversation

haagha
Copy link
Member

@haagha haagha commented Nov 3, 2023 •
edited
Loading

Description

Adding new parameter VirtualMachineScaleSetId and reducing permissions for private key when generating SSH key.

(https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1374)

#16843

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 3, 2023 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Update-AzVM 1 1 Unassigned_Variable Update-AzVM -VM $VirtualMachine is a null-valued parameter value. -VM Assign value for $VirtualMachine.
⚠️ Update-AzVM 2 13 Unassigned_Variable New-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzVM 2 16 Unassigned_Variable Update-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Update-AzVM 1 1 Unassigned_Variable Update-AzVM -VM $VirtualMachine is a null-valued parameter value. -VM Assign value for $VirtualMachine.
⚠️ Update-AzVM 2 13 Unassigned_Variable New-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
⚠️ Update-AzVM 2 16 Unassigned_Variable Update-AzVM -ResourceGroupName $rgname is a null-valued parameter value. -ResourceGroupName Assign value for $rgname.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Ssh
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@haagha haagha marked this pull request as ready for review November 6, 2023 13:49
@grizzlytheodore
Copy link
Member

grizzlytheodore commented Nov 6, 2023 •
edited
Loading

please resolve all CI failures and add changelog

@haagha
Copy link
Member Author

haagha commented Nov 6, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@haagha haagha requested a review from Sandido November 6, 2023 21:53
@VeryEarly VeryEarly self-assigned this Nov 7, 2023
Sandido
Sandido requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Sandido Sandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some concerns with other changes being bundled in here by accident regarding SSHKey stuff.

src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1 Outdated Show resolved Hide resolved
src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs Show resolved Hide resolved
src/Compute/Compute/Compute.csproj Show resolved Hide resolved
src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs Show resolved Hide resolved
@haagha haagha changed the title [Compute] Update-Azvm changes [Compute] VirtualMachineScaleSetId Parameter for Update-Azvm and Reduced File permissions for SSH key Nov 7, 2023
@haagha
Copy link
Member Author

haagha commented Nov 7, 2023 •
edited
Loading

some concerns with other changes being bundled in here by accident regarding SSHKey stuff.

@Sandido SSH File permission change and Update-Azvm change need to be tested together, bundling these changes to avoid any merge issues.

Sandido
Sandido previously approved these changes Nov 7, 2023
View reviewed changes
@haagha
Copy link
Member Author

haagha commented Nov 7, 2023 •
edited
Loading

@VeryEarly PR was approved, but I had to rerecord test because of @Sandido TrustedLaunch changes.

Sandido
Sandido previously approved these changes Nov 8, 2023
View reviewed changes
@VeryEarly VeryEarly changed the base branch from main to release-2023-11-14 November 8, 2023 00:41
@VeryEarly VeryEarly dismissed Sandido’s stale review November 8, 2023 00:41

The base branch was changed.

@VeryEarly VeryEarly merged commit 297fa4f into release-2023-11-14 Nov 8, 2023
12 checks passed
@VeryEarly VeryEarly deleted the haagha/vmscalesetidnull branch November 8, 2023 01:37
@haagha haagha mentioned this pull request Nov 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

@Sandido Sandido Sandido left review comments

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms

@grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

Assignees

@VeryEarly VeryEarly

Labels
None yet
Projects
None yet
Milestone
Az 11.0.0 (November 2023, 2023-11-14)...
Development

Successfully merging this pull request may close these issues.
4 participants
@haagha @grizzlytheodore @VeryEarly @Sandido