[Compute] Revert Generate-SSH file permission changes because of Clou…

…dshell failure (#23477) * reverting changes for file permissions of private key using New-Azvm * Update ChangeLog.md --------- Co-authored-by: NoriZC <[email protected]>
Azure · Nov 28, 2023 · e4e2930 · e4e2930
1 parent 33cff08
commit e4e2930
Show file tree

Hide file tree

Showing 4 changed files with 800 additions and 974 deletions.
diff --git a/src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs b/src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs
@@ -445,7 +445,7 @@ public void TestCapacityReservation()
             TestRunner.RunTestScript("Test-CapacityReservation");
         }
 
-        [Fact(Skip = "Cannot run on Github Platform due to ACL API")]
+        [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestVMwithSSHKey()
         {

diff --git a/...osoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests/TestVMwithSSHKey.json b/...osoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineTests/TestVMwithSSHKey.json
diff --git a/src/Compute/Compute/ChangeLog.md b/src/Compute/Compute/ChangeLog.md
@@ -25,6 +25,7 @@
 * Added new examples in `New-AzVM` and `New-AzVmss` for TrustedLaunch default usage.
 * Fixed the `New-AzVM` bug to avoid accessing the `EncryptionAtHost` property for subscriptions who cannot access it since it is behind a feature flag.
 * Updated `Get-AzVmExtension` to return instanceView when used with `-Status`.
+* Reverted SSH Private Key File permission changes in `New-AzVm`.
 
 ## Version 7.0.0
 * Added update functionality in `Update-AzVmss` for parameters `SecurityType`, `EnableSecureBoot`, and `EnableVtpm` for the parameter set with the Put operation.

diff --git a/src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs b/src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
@@ -1566,23 +1566,6 @@ private string GenerateOrFindSshKey()
                     }
                     Console.WriteLine("Private key is saved to " + privateKeyFilePath);
 
-                    FileSecurity fileSecurity = new FileSecurity(privateKeyFilePath, AccessControlSections.Access);
-                    // Define the owner's identity
-                    IdentityReference owner = new SecurityIdentifier(WellKnownSidType.BuiltinUsersSid, null);
-
-                    // Create an access rule for the owner with read and write permissions (0600)
-                    FileSystemAccessRule rule = new FileSystemAccessRule(
-                        owner,
-                        FileSystemRights.Read | FileSystemRights.Write,
-                        AccessControlType.Allow
-                    );
-
-                    // Add the access rule to the file security
-                    fileSecurity.AddAccessRule(rule);
-
-                    FileInfo fileinfo = new FileInfo(privateKeyFilePath);
-                    fileinfo.SetAccessControl(fileSecurity);
-
                     using (StreamWriter writer = new StreamWriter(publicKeyFilePath))
                     {
                         writer.WriteLine(keypair.PublicKey);