-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IsDisabled
property to worker description and skip if the value is True
#10231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitting some minor comments, but also had a design sync with @kshyju
src/WebJobs.Script/Workers/Rpc/Configuration/RpcWorkerConfigFactory.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/Workers/Rpc/Configuration/RpcWorkerConfigFactory.cs
Outdated
Show resolved
Hide resolved
IsDisabled
property to worker description and skip if the value is True
After syncing with fabio, I pushed an iteration where I changed the property to a more generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit comment, but the change looks good!
… is True (#10231) * Adding support to skip a worker description when none of the profile conditions are met. * Adding release notes. * Changes to switch to "IsDisabled" property on worker description. * missed a file
Fixes #9932
Adding
IsDisabled
property to worker description. This allows language workers to enable/disable a worker based on profile conditions. This is an optional property. If not provided, the worker will not be skipped.Here is a sample worker config which takes advantage of this property.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredWill follow backport PR.[InProc] AddIsDisabled
property to worker description and skip if the value is True #10250release_notes.md
IsDisabled
property to worker description and skip if the value is True #10250Additional information
Additional PR information