Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InProc] Add IsDisabled property to worker description and skip if the value is True #10250

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[InProc] Add IsDisabled property to worker description and skip if the value is True #10250

merged 1 commit into from
Jun 27, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Jun 25, 2024

Backporting #10231

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju
Add IsDisabled property to worker description and skip if the value…
c16edaa 
… is True (#10231)

* Adding support to skip a worker description when none of the profile conditions are met.

* Adding release notes.

* Changes to switch to "IsDisabled" property on worker description.

* missed a file
@kshyju kshyju requested a review from a team as a code owner June 25, 2024 23:32
@kshyju kshyju mentioned this pull request Jun 25, 2024
Merged
9 tasks
@kshyju kshyju merged commit 0932b7a into in-proc Jun 27, 2024
22 checks passed
@kshyju kshyju deleted the shkr/gh-9932-skip-profile-inproc branch June 27, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettsam brettsam brettsam approved these changes

@jviau jviau jviau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyju @brettsam @jviau