Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FNH worker config to only start worker in placeholder mode. #2552

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Jul 1, 2024

Fixes #2501

Changes in this PR leverage the modifications introduced in Azure/azure-functions-host#10231 to disable a worker profile. In this PR, I updated the dotnet isolated worker.config to ensure it starts only in placeholder mode by checking specific environment variable values. If these values are absent, a fallback profile is selected, which disables the worker. This ensures that the dotnet isolated worker does not start after specialization is complete.

Environment variables to be present for the worker to be included:

Windows
  1. WEBSITE_PLACEHOLDER_MODE = 1
Linux
  1. WEBSITE_PLACEHOLDER_MODE = 1
  2. WEBSITE_CONTAINER_READY = 0

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested review from brettsam and fabiocav July 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add profile condition to FunctionsNetHost worker config to check host is in placeholder mode
3 participants