fix: remove fee juice mint public

[sklppy88]

Addresses #8081

One thing that I was wondering, will this new introduction of bridging here add too much overhead in the tests ?

[sklppy88]

• fix: remove fee juice mint public #8260 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,782	1,572 (+1%)	723 (+1%)	762	785 (+1%)
proof_construction_time_sha256_30_ms	11,589 (+1%)	3,139 (+2%)	1,412 (+2%)	1,463 (+2%)	1,493 (+2%)
proof_construction_time_sha256_100_ms	44,803 (+1%)	12,156 (+1%)	5,814 (+7%)	5,893 (+6%)	5,824 (+2%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	58.0 (+2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,531	423	204	227 (-1%)	274 (+2%)
proof_construction_time_poseidon_hash_100_ms	5,667	1,521 (+1%)	684 (+1%)	739 (-1%)	755 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,172	92,966	177,976
l1_rollup_execution_gas	845,506	1,579,196	3,364,262
l2_block_processing_time_in_ms	251 (-1%)	441	804
l2_block_building_time_in_ms	11,451 (+1%)	22,381	44,730 (+1%)
l2_block_rollup_simulation_time_in_ms	11,451 (+1%)	22,381	44,730 (+1%)
l2_block_public_tx_process_time_in_ms	9,764 (+1%)	20,679	42,972 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,936 (-3%)	3,849 (+1%)
node_database_size_in_bytes	12,644,432	16,744,528
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	91.3 (-1%)	396 (-1%)	21,474 (-1%)	44,898	N/A
private-kernel-inner	176 (-1%)	705	72,411	45,020	N/A
private-kernel-reset-tiny	311 (-1%)	716	65,240 (-1%)	44,886	N/A
private-kernel-tail	168 (+1%)	136	50,608	52,921 (+1%)	N/A
base-parity	5.59 (-1%)	N/A	160	96.0	N/A
root-parity	35.3	N/A	73,948	96.0	N/A
base-rollup	2,744 (-7%)	N/A	189,163	664	N/A
block-root-rollup	41.6	N/A	58,205	2,448	N/A
public-kernel-setup	85.2	N/A	105,085	71,222	N/A
public-kernel-app-logic	96.9	N/A	104,903	71,222	N/A
public-kernel-tail	859	N/A	390,582	16,414	N/A
private-kernel-reset-small	311	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	674 (+1%)	612	455,400	1,825	N/A
public-kernel-teardown	84.2	N/A	105,349	71,222	N/A
merge-rollup	20.0 (+1%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	78,859 (-1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.3
MultiCallEntrypoint:entrypoint	1,920	11,731	403
FeeJuice:deploy	1,376	11,731	389
SchnorrAccount:constructor	1,312	11,731	73.6 (+1%)
SchnorrAccount:entrypoint	2,336	11,731	386 (-2%)
FeeJuice:claim	1,344	11,731	37.9
Token:privately_mint_private_note	1,280	11,731	106 (+3%)
FPC:fee_entrypoint_public	1,344	11,731	32.2 (+15%)
Token:transfer	1,312	11,731	230
Benchmarking:create_note	1,344	11,731	85.7 (-2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.5
Token:unshield	1,376	11,731	523 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	696

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	49.5 (-14%)	8,174
FeeJuice:set_portal	11.2 (-6%)	4,055
Token:constructor	81.1 (-2%)	29,082
FPC:constructor	56.5 (+1%)	18,940
FeeJuice:check_balance	38.6	5,978
Token:mint_public	47.0 (-7%)	12,704
Token:assert_minter_and_mint	323 (+1%)	8,467
AuthRegistry:set_authorized	48.1 (-2%)	4,194
FPC:prepare_fee	247 (+2%)	6,747
Token:transfer_public	23.9 (+5%)	39,863
FPC:pay_refund	60.1 (-9%)	9,398
Benchmarking:increment_balance	1,223	7,263
Token:_increase_public_balance	41.5	8,686
FPC:pay_refund_with_shielded_rebate	61.3 (-1%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.159

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16 (-1%)	3.94 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112 (-1%)	0.111 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3 (+1%)	17.6 (+2%)	30.6	58.5	116 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108 (+1%)	0.102 (+1%)	0.0996	0.101	0.103 (+3%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.5 (+1%)	25.6 (+1%)	43.6	82.6 (+1%)	162 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	108 (-1%)	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.112 (+1%)	0.104 (+1%)	0.105	0.102 (+1%)	0.103
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	131 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,838	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[just-mitch]

👍 Thank you!