fix: Docker.dockerignore file can be huge. #8023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcarreiro
approved these changes
Aug 15, 2024
rahul-kothari
pushed a commit
that referenced
this pull request
Aug 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.49.1</summary> ## [0.49.1](aztec-package-v0.49.0...aztec-package-v0.49.1) (2024-08-15) ### Miscellaneous * Sync alphanet back to master ([#7970](#7970)) ([523724d](523724d)) </details> <details><summary>barretenberg.js: 0.49.1</summary> ## [0.49.1](barretenberg.js-v0.49.0...barretenberg.js-v0.49.1) (2024-08-15) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.49.1</summary> ## [0.49.1](aztec-packages-v0.49.0...aztec-packages-v0.49.1) (2024-08-15) ### Features * Add pending reorg chain resistance in contracts ([#7926](#7926)) ([f769f84](f769f84)) * **avm:** Base and dynamic gas in TS and CPP (part 2) ([#8016](#8016)) ([5801732](5801732)) ### Bug Fixes * Docker.dockerignore file can be huge. ([#8023](#8023)) ([cee9d9a](cee9d9a)) * Forking world state in prover-node ([#7995](#7995)) ([ebffe96](ebffe96)) ### Miscellaneous * **avm:** Separate binary and bytes finalization ([#8010](#8010)) ([3ad6dd9](3ad6dd9)) * Private reset kernel ([#7984](#7984)) ([0d82c79](0d82c79)) * Sync alphanet back to master ([#7970](#7970)) ([523724d](523724d)) </details> <details><summary>barretenberg: 0.49.1</summary> ## [0.49.1](barretenberg-v0.49.0...barretenberg-v0.49.1) (2024-08-15) ### Features * **avm:** Base and dynamic gas in TS and CPP (part 2) ([#8016](#8016)) ([5801732](5801732)) ### Miscellaneous * **avm:** Separate binary and bytes finalization ([#8010](#8010)) ([3ad6dd9](3ad6dd9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this pull request
Aug 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.49.1</summary> ## [0.49.1](AztecProtocol/aztec-packages@aztec-package-v0.49.0...aztec-package-v0.49.1) (2024-08-15) ### Miscellaneous * Sync alphanet back to master ([#7970](AztecProtocol/aztec-packages#7970)) ([523724d](AztecProtocol/aztec-packages@523724d)) </details> <details><summary>barretenberg.js: 0.49.1</summary> ## [0.49.1](AztecProtocol/aztec-packages@barretenberg.js-v0.49.0...barretenberg.js-v0.49.1) (2024-08-15) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.49.1</summary> ## [0.49.1](AztecProtocol/aztec-packages@aztec-packages-v0.49.0...aztec-packages-v0.49.1) (2024-08-15) ### Features * Add pending reorg chain resistance in contracts ([#7926](AztecProtocol/aztec-packages#7926)) ([f769f84](AztecProtocol/aztec-packages@f769f84)) * **avm:** Base and dynamic gas in TS and CPP (part 2) ([#8016](AztecProtocol/aztec-packages#8016)) ([5801732](AztecProtocol/aztec-packages@5801732)) ### Bug Fixes * Docker.dockerignore file can be huge. ([#8023](AztecProtocol/aztec-packages#8023)) ([cee9d9a](AztecProtocol/aztec-packages@cee9d9a)) * Forking world state in prover-node ([#7995](AztecProtocol/aztec-packages#7995)) ([ebffe96](AztecProtocol/aztec-packages@ebffe96)) ### Miscellaneous * **avm:** Separate binary and bytes finalization ([#8010](AztecProtocol/aztec-packages#8010)) ([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9)) * Private reset kernel ([#7984](AztecProtocol/aztec-packages#7984)) ([0d82c79](AztecProtocol/aztec-packages@0d82c79)) * Sync alphanet back to master ([#7970](AztecProtocol/aztec-packages#7970)) ([523724d](AztecProtocol/aztec-packages@523724d)) </details> <details><summary>barretenberg: 0.49.1</summary> ## [0.49.1](AztecProtocol/aztec-packages@barretenberg-v0.49.0...barretenberg-v0.49.1) (2024-08-15) ### Features * **avm:** Base and dynamic gas in TS and CPP (part 2) ([#8016](AztecProtocol/aztec-packages#8016)) ([5801732](AztecProtocol/aztec-packages@5801732)) ### Miscellaneous * **avm:** Separate binary and bytes finalization ([#8010](AztecProtocol/aztec-packages#8010)) ([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run into some nutty error when dockerignore files get large (circleci path):
This became the case with avm-transpiler as it's build context is the root of the monorepo so it can gain access to the noir source code. The autogenerated dockerignore file has to explicitly list every file in he monorepo as a reverse match which eventually got so big something broke internally to docker.
New script will not autogen the dockerignore file if its committed to git. This PR includes a manually crafted one for avm-transpiler.