Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sync alphanet back to master #7970

Merged
merged 8 commits into from
Aug 15, 2024
Merged

chore: Sync alphanet back to master #7970

merged 8 commits into from
Aug 15, 2024

Conversation

spalladino
Copy link
Collaborator

No description provided.

@AztecBot
Copy link
Collaborator

AztecBot commented Aug 14, 2024

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (FeeJuice:set_portal): 19.9 (+99%)
  • avm_simulation_time_ms (Token:transfer_public): 29.3 (+32%)
  • avm_simulation_time_ms (FPC:pay_refund): 71.2 (+34%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,759 1,558 711 (+1%) 751 (-1%) 769 (+1%)
proof_construction_time_sha256_30_ms 11,882 (+1%) 3,196 (+1%) 1,422 (+1%) 1,433 1,478 (+1%)
proof_construction_time_sha256_100_ms 45,387 12,149 5,526 (+2%) 5,444 (+1%) 5,456 (+2%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 58.0 (-2%) 88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms 1,530 420 204 228 268 (-1%)
proof_construction_time_poseidon_hash_100_ms 5,644 1,507 677 725 (-1%) 744

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,324 7,844 14,852
l1_rollup_calldata_gas 49,696 92,380 177,596
l1_rollup_execution_gas 1,294,359 2,042,011 3,869,266
l2_block_processing_time_in_ms 256 459 (+5%) 816 (+1%)
l2_block_building_time_in_ms 9,379 18,141 36,245
l2_block_rollup_simulation_time_in_ms 9,379 18,140 36,245
l2_block_public_tx_process_time_in_ms 7,878 16,592 34,640 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 3,005 (+7%) 3,894 (+2%)
node_database_size_in_bytes 12,623,952 16,707,664
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 101 (-1%) 393 (+1%) 21,846 44,858 N/A
private-kernel-inner 168 711 (+1%) 72,545 45,005 N/A
private-kernel-reset-tiny 504 (-1%) 1,197 (+1%) 69,614 44,844 N/A
private-kernel-tail 269 (-1%) 196 (+1%) 50,760 52,256 N/A
base-parity 5.51 N/A 160 96.0 N/A
root-parity 33.2 (+1%) N/A 69,084 96.0 N/A
base-rollup 2,855 N/A 187,817 664 N/A
root-rollup 38.7 (+1%) N/A 54,525 716 N/A
public-kernel-setup 100 (+1%) N/A 103,760 71,222 N/A
public-kernel-app-logic 106 N/A 103,599 71,222 N/A
public-kernel-tail 571 N/A 409,190 16,414 N/A
private-kernel-reset-small 482 N/A 66,533 45,629 N/A
private-kernel-tail-to-public 1,478 712 (+1%) 507,554 1,697 N/A
public-kernel-teardown 95.9 (+2%) N/A 104,005 71,222 N/A
merge-rollup 19.3 (+1%) N/A 35,742 664 N/A
undefined N/A N/A N/A N/A 72,335 (+7%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 341 (-2%)
ContractInstanceDeployer:deploy 1,408 11,731 18.2
MultiCallEntrypoint:entrypoint 1,920 11,731 421 (-1%)
FeeJuice:deploy 1,376 11,731 390
SchnorrAccount:constructor 1,312 11,731 104 (-1%)
SchnorrAccount:entrypoint 2,304 11,731 432 (-1%)
Token:privately_mint_private_note 1,280 11,731 138
FPC:fee_entrypoint_public 1,344 11,731 27.8 (+9%)
Token:transfer 1,312 11,731 286
Benchmarking:create_note 1,344 11,731 103 (-1%)
SchnorrAccount:verify_private_authwit 1,280 11,731 27.4 (-1%)
Token:unshield 1,376 11,731 550 (-2%)
FPC:fee_entrypoint_private 1,376 11,731 753

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 44.0 (-16%) 8,139
FeeJuice:set_portal ⚠️ 19.9 (+99%) 2,362
Token:constructor 81.1 (-2%) 31,107
FPC:constructor 51.8 (-6%) 22,380
FeeJuice:mint_public 37.8 6,150
Token:mint_public 46.6 (+11%) 11,720
Token:assert_minter_and_mint 67.8 8,028
AuthRegistry:set_authorized 36.8 (-3%) 4,537
FPC:prepare_fee 261 (+12%) 8,812
Token:transfer_public ⚠️ 29.3 (+32%) 47,374
FPC:pay_refund ⚠️ 71.2 (+34%) 12,114
Benchmarking:increment_balance 969 (-1%) 7,450
Token:_increase_public_balance 40.4 8,960
FPC:pay_refund_with_shielded_rebate 66.7 (+1%) 12,663

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.165 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.20 (+2%) 3.89 (+2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.114 (+3%) 0.110 (+2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.6 (+1%) 18.0 (+1%) 31.1 (+1%) 61.5 (+4%) 112 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.111 (+1%) 0.105 (+2%) 0.101 (+1%) 0.107 (+6%) 0.101
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.2 (-2%) 26.6 (+3%) 43.4 (-1%) 89.2 (+9%) 161 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.107 (-3%) 0.107 (+3%) 0.102 (-4%) 0.112 (+11%) 0.102 (-1%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.7 (+3%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.107 (+3%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

In case tmpdir() is not available, rely on the data dir for creating
forks of the store.
Add logs to forking and a catch to the prover job.
This allows executing commands from the AWS CLI directly on the
containers for troubleshooting.
Attempt to fix the `Error in prover node work: Error No such file or
directory` error in prover-node when forking. Tested by connecting to
the container, modifying the js, and running prover-node manually.
@spalladino spalladino marked this pull request as ready for review August 15, 2024 13:54
@spalladino spalladino merged commit 523724d into master Aug 15, 2024
27 checks passed
@spalladino spalladino deleted the alphanet branch August 15, 2024 13:58
@spalladino spalladino restored the alphanet branch August 15, 2024 13:58
@spalladino spalladino deleted the alphanet branch August 15, 2024 13:59
rahul-kothari pushed a commit that referenced this pull request Aug 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](#7926))
([f769f84](f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](#8023))
([cee9d9a](cee9d9a))
* Forking world state in prover-node
([#7995](#7995))
([ebffe96](ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
* Private reset kernel
([#7984](#7984))
([0d82c79](0d82c79))
* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](AztecProtocol/aztec-packages#7926))
([f769f84](AztecProtocol/aztec-packages@f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](AztecProtocol/aztec-packages#8023))
([cee9d9a](AztecProtocol/aztec-packages@cee9d9a))
* Forking world state in prover-node
([#7995](AztecProtocol/aztec-packages#7995))
([ebffe96](AztecProtocol/aztec-packages@ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
* Private reset kernel
([#7984](AztecProtocol/aztec-packages#7984))
([0d82c79](AztecProtocol/aztec-packages@0d82c79))
* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants