Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forking world state in prover-node #7995

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix: Forking world state in prover-node #7995

merged 3 commits into from
Aug 15, 2024

Conversation

spalladino
Copy link
Collaborator

Attempt to fix the Error in prover node work: Error No such file or directory error in prover-node when forking. Tested by connecting to the container, modifying the js, and running prover-node manually.

Attempt to fix the `Error in prover node work: Error No such file or
directory` error in prover-node when forking. Tested by connecting to
the container, modifying the js, and running prover-node manually.
@AztecBot
Copy link
Collaborator

AztecBot commented Aug 14, 2024

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (Token:transfer_public): 20.5 (-37%)
  • avm_simulation_time_ms (Token:_increase_public_balance): 76.1 (+93%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,763 1,558 705 (-1%) 758 (+1%) 774
proof_construction_time_sha256_30_ms 11,896 3,188 (-1%) 1,420 1,436 (-1%) 1,468 (-1%)
proof_construction_time_sha256_100_ms 45,470 (-1%) 11,943 (-1%) 5,474 (-1%) 5,422 (-1%) 5,411 (-1%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 (-3%) 59.0 (+2%) 88.0
proof_construction_time_poseidon_hash_30_ms 1,530 422 202 (-1%) 237 (+2%) 274 (+1%)
proof_construction_time_poseidon_hash_100_ms 5,645 1,513 678 725 (+1%) 754

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,324 7,844 14,852
l1_rollup_calldata_gas 49,696 92,492 177,692
l1_rollup_execution_gas 1,294,359 2,042,123 3,869,362
l2_block_processing_time_in_ms 252 (-2%) 440 (+1%) 787 (-2%)
l2_block_building_time_in_ms 9,352 (-1%) 18,189 36,310
l2_block_rollup_simulation_time_in_ms 9,351 (-1%) 18,188 36,310
l2_block_public_tx_process_time_in_ms 7,882 (-1%) 16,628 34,713

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 2,963 3,795 (+2%)
node_database_size_in_bytes 12,615,760 16,711,760
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 101 (+6%) 396 (+1%) 21,846 44,858 N/A
private-kernel-inner 169 (-2%) 735 (+5%) 72,545 45,005 N/A
private-kernel-reset-tiny 508 (+2%) 1,201 (-1%) 69,614 44,844 N/A
private-kernel-tail 272 (+1%) 194 (-2%) 50,760 52,256 N/A
base-parity 5.55 (-1%) N/A 160 96.0 N/A
root-parity 33.1 N/A 69,084 96.0 N/A
base-rollup 2,875 N/A 187,817 664 N/A
root-rollup 38.4 N/A 54,525 716 N/A
public-kernel-setup 100 N/A 103,760 71,222 N/A
public-kernel-app-logic 106 N/A 103,599 71,222 N/A
public-kernel-tail 571 N/A 409,190 16,414 N/A
private-kernel-reset-small 486 (+1%) N/A 66,533 45,629 N/A
private-kernel-tail-to-public 1,486 (+13%) 709 507,554 1,697 N/A
public-kernel-teardown 95.3 (+1%) N/A 104,005 71,222 N/A
merge-rollup 19.1 N/A 35,742 664 N/A
undefined N/A N/A N/A N/A 66,932 (-3%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 347
ContractInstanceDeployer:deploy 1,408 11,731 18.1
MultiCallEntrypoint:entrypoint 1,920 11,731 424
FeeJuice:deploy 1,376 11,731 397 (+1%)
SchnorrAccount:constructor 1,312 11,731 104 (-1%)
SchnorrAccount:entrypoint 2,304 11,731 432
Token:privately_mint_private_note 1,280 11,731 139
FPC:fee_entrypoint_public 1,344 11,731 28.5 (+2%)
Token:transfer 1,312 11,731 283
Benchmarking:create_note 1,344 11,731 100
SchnorrAccount:verify_private_authwit 1,280 11,731 27.5 (-1%)
Token:unshield 1,376 11,731 556 (-1%)
FPC:fee_entrypoint_private 1,376 11,731 754 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 53.3 (-2%) 8,139
FeeJuice:set_portal 9.26 (-12%) 2,362
Token:constructor 82.8 (+2%) 31,107
FPC:constructor 52.5 (-2%) 22,380
FeeJuice:mint_public 38.0 (+1%) 6,150
Token:mint_public 71.3 11,720
Token:assert_minter_and_mint 38.8 (-2%) 8,028
AuthRegistry:set_authorized 43.7 (-4%) 4,537
FPC:prepare_fee 232 (+1%) 8,812
Token:transfer_public ⚠️ 20.5 (-37%) 47,374
FPC:pay_refund 61.8 (+7%) 12,114
Benchmarking:increment_balance 974 7,450
Token:_increase_public_balance ⚠️ 76.1 (+93%) 8,960
FPC:pay_refund_with_shielded_rebate 67.6 (+2%) 12,663

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.171 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.17 (+1%) 3.89 (+2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.112 (+1%) 0.110 (+3%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.3 17.4 (-3%) 30.7 (-1%) 58.6 109 (-4%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.109 0.101 (-3%) 0.0995 (-1%) 0.101 0.0985 (-4%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.4 24.9 (-3%) 43.2 (-1%) 82.2 158 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.109 0.101 (-3%) 0.104 (-1%) 0.101 (-1%) 0.0994 (-3%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.3 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.105 N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

Copy link
Contributor

github-actions bot commented Aug 15, 2024

Changes to circuit sizes

Generated at commit: fb0e87f2e0e5ec6d0d0c4edd329f61f6e4df5876, compared to commit: 3d61bdfbe16464e19523d20f231fbd3ff76f509c

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_tail -9 ✅ -0.00% -9 ✅ -0.00%
rollup_base -23 ✅ -0.01% -23 ✅ -0.00%
public_kernel_teardown -36 ✅ -0.01% -44 ✅ -0.00%
public_kernel_app_logic -36 ✅ -0.01% -45 ✅ -0.01%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_tail 1,005,149 (-9) -0.00% 9,385,243 (-9) -0.00%
rollup_base 348,208 (-23) -0.01% 9,076,523 (-23) -0.00%
public_kernel_teardown 295,080 (-36) -0.01% 1,914,718 (-44) -0.00%
public_kernel_app_logic 294,532 (-36) -0.01% 596,065 (-45) -0.01%

@PhilWindle PhilWindle enabled auto-merge (squash) August 15, 2024 11:21
@PhilWindle PhilWindle merged commit ebffe96 into master Aug 15, 2024
93 of 94 checks passed
@PhilWindle PhilWindle deleted the palla/fix-fork branch August 15, 2024 11:51
rahul-kothari pushed a commit that referenced this pull request Aug 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](#7926))
([f769f84](f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](#8023))
([cee9d9a](cee9d9a))
* Forking world state in prover-node
([#7995](#7995))
([ebffe96](ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
* Private reset kernel
([#7984](#7984))
([0d82c79](0d82c79))
* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](AztecProtocol/aztec-packages#7926))
([f769f84](AztecProtocol/aztec-packages@f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](AztecProtocol/aztec-packages#8023))
([cee9d9a](AztecProtocol/aztec-packages@cee9d9a))
* Forking world state in prover-node
([#7995](AztecProtocol/aztec-packages#7995))
([ebffe96](AztecProtocol/aztec-packages@ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
* Private reset kernel
([#7984](AztecProtocol/aztec-packages#7984))
([0d82c79](AztecProtocol/aztec-packages@0d82c79))
* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants