feat: Sync from noir

[AztecBot]

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
feat(nargo): Multiple circuits info for binary programs (noir-lang/noir#4719)
chore: update condition for clearing warning comment on release PRs (noir-lang/noir#4739)
chore(ci): fix cutting new versions of the docs (noir-lang/noir#4737)
chore(ci): replace yarn build:js:only script (noir-lang/noir#4735)
chore: update JS publish workflow to upload build artifacts correctly. (noir-lang/noir#4734)
feat: add remove_enable_side_effects SSA pass (noir-lang/noir#4224)
chore: update from vulnerable version of h2 (noir-lang/noir#4714)
chore(ci): stop updating version list before cutting new docs version (noir-lang/noir#4726)
chore: remove FunctionInput::dummy (noir-lang/noir#4723)
chore: remove docker CI flow (noir-lang/noir#4724)
fix: unknown slice lengths coming from as_slice (noir-lang/noir#4725)
chore: remove unused env vars from Cross.toml (noir-lang/noir#4717)
feat: improve nargo check cli with --override flag and feedback for existing files (noir-lang/noir#4575)
feat: Allow slices to brillig entry points (noir-lang/noir#4713)
chore: simplify how acvm_backend.wasm is embedded (noir-lang/noir#4703)
fix(acvm): Mark outputs of Opcode::Call solvable (noir-lang/noir#4708)
fix: Field comparisons (noir-lang/noir#4704)
feat(acvm_js): Execute program (noir-lang/noir#4694)
chore: simplify how blns is loaded into tests (noir-lang/noir#4705)
fix(ssa): Do not use get_value_max_num_bits when we want pure type information (noir-lang/noir#4700)
chore: remove conditional compilation around acvm_js package (noir-lang/noir#4702)
feat(docs): Documenting noir codegen (noir-lang/noir#4454)
chore: check for references to private functions during path resolution (noir-lang/noir#4622)
chore: fix clippy errors (noir-lang/noir#4684)
fix: Last use analysis & make it an SSA pass (noir-lang/noir#4686)
feat: improve SSA type-awareness in EQ and MUL instructions (noir-lang/noir#4691)
feat: improve optimisations on range constraints (noir-lang/noir#4690)
chore: remove last traces of nix (noir-lang/noir#4679)
chore: Use is_entry_point helper on RuntimeType (noir-lang/noir#4678)
END_COMMIT_OVERRIDE

[vezenovm]

Too many conflicts I thought after Alvaro's fixes it might sync.

[sirasistant]

Yep I don't know which commit does the subrepo flow use for the base of these sync branches

[AztecBot]

Benchmark results

Metrics with a significant change:

• tx_sequencer_processing_time_ms (5): 1,725 (-18%)
• tx_sequencer_processing_time_ms (8): 565 (-22%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f038b704 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,412	6,412
l1_rollup_execution_gas	585,757	585,745	585,745
l2_block_processing_time_in_ms	1,272 (-3%)	4,663 (-1%)	9,110 (-2%)
note_successful_decrypting_time_in_ms	170 (-27%)	541 (-4%)	1,007 (-6%)
note_trial_decrypting_time_in_ms	46.6 (+42%)	47.3 (-35%)	26.0 (-65%)
l2_block_building_time_in_ms	11,497 (-3%)	41,704 (-3%)	83,670
l2_block_rollup_simulation_time_in_ms	11,460 (-3%)	41,592 (-3%)	83,454
l2_block_public_tx_process_time_in_ms	5,922 (-4%)	23,264 (-3%)	48,143 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,709 (-3%)	25,687 (-6%)
note_history_successful_decrypting_time_in_ms	1,237 (-5%)	2,282 (-6%)
note_history_trial_decrypting_time_in_ms	53.7 (-22%)	71.8 (-32%)
node_database_size_in_bytes	18,649,168	34,947,152
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	174 (-3%)	44,377	26,164
private-kernel-ordering	155 (-4%)	50,830	39,026
base-parity	3,861 (-3%)	128	311
root-parity	1,037 (-5%)	1,244	311
base-rollup	13,891 (-2%)	110,464	861
root-rollup	48.4 (-3%)	4,359	725
private-kernel-inner	210 (-3%)	71,744	26,164
public-kernel-app-logic	117 (-2%)	47,695	40,661
public-kernel-tail	159 (-3%)	53,372	7,125
merge-rollup	9.60 (-13%)	2,568	861
public-kernel-teardown	115 (-19%)	47,695	40,661
public-kernel-setup	114 (-3%)	47,695	40,661

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.77 (-3%)	15.5 (-5%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.570 (-3%)	0.480 (-5%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	44.8 (-4%)	70.5 (-3%)	225 (-3%)	431 (-4%)	853 (-2%)	1,696 (-2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.459 (-4%)	0.435 (-3%)	0.410 (-3%)	0.403 (-4%)	0.406 (-2%)	0.405 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.1 (-4%)	103 (-4%)	330 (-3%)	638 (-4%)	1,280 (-2%)	2,551 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.469 (-3%)	0.467 (-3%)	0.448 (-2%)	0.439 (-4%)	0.445 (-2%)	0.443 (-3%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	59.3 (-4%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.518 (-4%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	40,372	496,534

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	905	1,161	1,377

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,642 (-3%)	1,044 (-3%)	5,354 (-1%)

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	558 (-3%)	396 (-1%)	1,036 (-4%)	476 (-9%)	⚠️ 1,725 (-18%)	⚠️ 565 (-22%)

[vezenovm]

@TomAFrench Gates diff is also going to fail for this initial PR

[vezenovm]

This looks good to merge