feat: variable_base_scalar_mul blackbox func

[benesjan]

Currently we only had fixed_base_scalar_mul blackbox function available. With the new key stuff we need variable base as well. This PR is an attempt at implementing that.

[benesjan]

• feat: computing sym key for incoming ciphertext #6020
• feat: variable_base_scalar_mul blackbox func #6039 👈
• fix: test_native.sh not running all noir tests #6075
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,680	6,692	6,692
l1_rollup_execution_gas	586,812	586,824	586,824
l2_block_processing_time_in_ms	1,468 (-13%)	5,491 (-3%)	10,584 (-2%)
l2_block_building_time_in_ms	22,630	89,003	178,170
l2_block_rollup_simulation_time_in_ms	22,423	88,253	176,696
l2_block_public_tx_process_time_in_ms	8,961 (-1%)	34,783	69,649 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	16,950 (-2%)	32,184 (+1%)
node_database_size_in_bytes	20,762,704	37,445,712
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	175 (-1%)	46,819	28,822
private-kernel-inner	205	76,734	28,822
private-kernel-ordering	228 (-1%)	53,040	42,751
base-parity	75.8 (+11%)	128	64.0
base-rollup	16,551	111,062	925
root-parity	1,697 (+5%)	27,064	64.0
root-rollup	65.1 (+1%)	11,454	789
public-kernel-app-logic	1,991	54,321	22,677
public-kernel-tail	4,872	159,770	3,898
merge-rollup	6,565 (+1%)	2,696	925
public-kernel-teardown	161	54,321	30,042
public-kernel-setup	220	54,321	30,042

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0	17.9 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.643	0.551	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.4 (+2%)	80.4 (+1%)	262	510 (+2%)	988	1,945 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.536 (+2%)	0.496	0.476	0.476 (+2%)	0.468	0.466	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	61.9 (+2%)	120	378 (+1%)	745 (+1%)	1,470	2,929	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.545 (+2%)	0.539	0.512	0.513 (+1%)	0.508	0.510	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	68.1 (+2%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.599 (+2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	44,613	535,433

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,401 (-1%)	1,005	3,668

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	893 (+1%)	789	1,418	934 (+1%)	2,183	1,118 (+1%)

[benesjan]

I will tackle this issue in a separate PR.

[benesjan]

I will tackle this issue in a separate PR.

[TomAFrench]

We can follow this up in a separate PR but we may want to instead expose an equivalent to batch_mul rather than a single variable base scalar multiplication. This would make it easier for the backend to use the optimal method when processing these.

[TomAFrench]

Opened an issue to replace this with an MSM opcode here: noir-lang/noir#4928

[vezenovm]

This passed? I would expect it to return a FixedBaseScalarMul

[benesjan]

It actually failed when I just run it locally. So there seems to be some CI issue. Great catch! Who needs a functional CI when you have Maxim 😆

[benesjan]

This started failing for me in CI but the code in this PR is not used in this test so it should not lead to slowdown.

[TomAFrench]

LGTM