feat: computing sym key for incoming ciphertext

[benesjan]

Fixes #5896
+ I nuked the curve argument from many functions because you can just instantiate it inside the functions - this is cheap since it uses singleton to fetch the BB wasm.

[benesjan]

• feat: computing sym key for incoming ciphertext #6020 👈
• feat: variable_base_scalar_mul blackbox func #6039
• fix: test_native.sh not running all noir tests #6075
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	740	740	740
l1_rollup_calldata_gas	6,668	6,692	6,668
l1_rollup_execution_gas	586,800	586,824	586,800
l2_block_processing_time_in_ms	1,615 (-4%)	5,461 (-4%)	10,360 (-4%)
l2_block_building_time_in_ms	22,356 (-1%)	87,975 (-1%)	175,391 (-2%)
l2_block_rollup_simulation_time_in_ms	22,151 (-1%)	87,237 (-1%)	173,933 (-2%)
l2_block_public_tx_process_time_in_ms	8,824 (-2%)	34,331 (-2%)	68,718 (-2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	17,250 (-1%)	30,410 (-5%)
node_database_size_in_bytes	20,766,800	37,429,328
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	178 (+1%)	46,819	28,822
private-kernel-inner	209 (+1%)	76,734	28,822
private-kernel-ordering	233 (+1%)	53,040	42,751
base-parity	73.6 (+7%)	128	64.0
base-rollup	16,439 (-1%)	111,062	925
root-parity	1,723 (+7%)	27,064	64.0
root-rollup	64.9	11,454	789
public-kernel-app-logic	1,991	54,321	22,677
public-kernel-tail	4,891	159,770	3,898
merge-rollup	6,506	2,696	925
public-kernel-teardown	160 (-1%)	54,321	30,042
public-kernel-setup	221	54,321	30,042

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.0 (+1%)	17.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.644	0.546	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	51.7	80.0	259 (-1%)	503 (+1%)	976 (-1%)	1,939 (-1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.527	0.494	0.473	0.469	0.464 (-1%)	0.463 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.8 (+1%)	120	375	742 (+1%)	1,462 (-1%)	2,918 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	105	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.534	0.540	0.512	0.509	0.506 (-1%)	0.507 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	66.9
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.587

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	44,613	535,433

Transaction size based on fee payment method

Metric	native fee payment method	fpc_public fee payment method	fpc_private fee payment method
tx_with_fee_size_in_bytes	897	1,145	1,345

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	1,393 (-1%)	1,023 (+1%)	3,665

Metric	1 public data writes	2 public data writes	3 public data writes	4 public data writes	5 public data writes	8 public data writes
tx_sequencer_processing_time_ms	888	786 (-1%)	1,409 (-1%)	926	2,184	1,104 (-1%)

[benesjan]

Did this so that it matches multiline variable assignment.

[LHerskind]

Added a few comments. Think we might be running into some pain around the emitEncryptedLog function as it is now as we would like to handle much more of that in the circuit with the extensions that we are currently looking at. So in my mind looks closer to us just passing the ciphertext directly instead 👀 But that will be when we use the AES encryption in there.

[LHerskind]

The deriveAESSecret as a name will be a pain with the outgoing as it derives an AES secret, but not from the point. secretAndPointToSymmetricKey incoming 😆

[LHerskind]

We will deal with the AES secret naming when we get to the outgoing.