Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): build noir artifacts in ci #1251

Merged
merged 27 commits into from
Jul 31, 2023
Merged

feat(ci): build noir artifacts in ci #1251

merged 27 commits into from
Jul 31, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Jul 27, 2023

Description

closes: #1248

  • Adds a build step before yarn project base that compiles the noir contracts using the nightly compiler version.
  • Adds an ephemeral layer to yarn project base to process the noir artifacts.

Dependencies

Uses the following build system pr in order to use multi stage builds of yarn project base.
AztecProtocol/build-system#16

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad
Copy link
Collaborator

ludamad commented Jul 27, 2023

@Maddiaa0 @spalladino well, I got further. I release the baton. Also not sure the Noir version we want has a public tar.gz

@ludamad ludamad force-pushed the md/artifacts-docker branch from 9e33482 to f8afbf8 Compare July 27, 2023 22:39
@ludamad ludamad force-pushed the md/artifacts-docker branch from f8afbf8 to 22066c1 Compare July 27, 2023 22:41
@Maddiaa0
Copy link
Member Author

Maddiaa0 commented Jul 28, 2023

@Maddiaa0 @spalladino well, I got further. I release the baton. Also not sure the Noir version we want has a public tar.gz

Looks like we can get nightlys through a tag which is bullish

@Maddiaa0 Maddiaa0 force-pushed the md/artifacts-docker branch from b85de97 to 5b53f7c Compare July 30, 2023 20:37
@Maddiaa0 Maddiaa0 force-pushed the md/artifacts-docker branch from 7546bc8 to 775a78e Compare July 30, 2023 21:57
@Maddiaa0 Maddiaa0 force-pushed the md/artifacts-docker branch 2 times, most recently from 11e6ebd to 4b285f7 Compare July 30, 2023 23:06
@Maddiaa0 Maddiaa0 force-pushed the md/artifacts-docker branch from 4b285f7 to 8a830d8 Compare July 30, 2023 23:16
@Maddiaa0 Maddiaa0 force-pushed the md/artifacts-docker branch from 2348480 to c78c5e9 Compare July 31, 2023 00:13
@Maddiaa0 Maddiaa0 marked this pull request as ready for review July 31, 2023 13:37
@Maddiaa0 Maddiaa0 requested a review from ludamad July 31, 2023 13:37
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lfg

@Maddiaa0 Maddiaa0 enabled auto-merge (squash) July 31, 2023 13:49
@Maddiaa0 Maddiaa0 merged commit 02c05f8 into master Jul 31, 2023
@Maddiaa0 Maddiaa0 deleted the md/artifacts-docker branch July 31, 2023 13:54
codygunton pushed a commit that referenced this pull request Jan 23, 2024
* Audit preperation (#1305)

* compiler warnings

* add solhint + fix small linter issues

* remove skipped tests

* update rollup address

* add underscores on arguments in IVerifier

* JB/Move global error to toast group (#1251)

* Move global error message inside toast group

* Mini refactor

* Mini refactor

* Add deferrals

* Blockchain test jest -> mocha update (#1314)

* run jest-to-mocha script

* Manually fix the last test + add coverage + formatting

* extend mocha timeout + bump optimizer runs

* decrease optimizer runs to deploy old rollup processor in testing

* remove coverage package, install on demand

* make solidity-coverage import a comment in hardhat config

* JB/Fix settlement times (#1315)

Fix batched time, fix button regression

* JB/Allow for debug to be exportable (#1313)

* Allow for debug to be exportable

* Remove exportable debug

* Rollback

* Refactor

* Tweak export logs

* Upgrade to latest bridge clients (#1319)

- Align with interface on latest bridge-clients
- Correct stETH address
- Calc element ROI via getTermAPR
- Calc stETH via getUnderlyingAsset

* Explain when to squash vs merge (#1302)

* Zw/update aztec connect specs (#1048)

* updated account circuit

* updated account circuit formatting

* updated schnorr spec

* updated intro

* fix typo

* updates in line with PR comments and rebase

Co-authored-by: Josh <[email protected]>
Co-authored-by: iAmMichaelConnor <[email protected]>

* Implemented rate limiting of deposits and address blacklist (#1323)

* Implemented rate limiting of deposits and address blacklist

* Cleanup

* Additionally check num deposits in tx receiver (#1326)

* Additionally check num deposits in tx receiver

* Sanity check input

* Additional tests (#1327)

* JB/Connect yearn bridge (#1334)

* Add yearn recipe

* Connect yearn bridge

* Fix toast z-index

* Fix price estimation for yearn bridge

* Take out console log

* Set up yvDAI bridge config

* Add styling for yearn (wip)

* Add price fetcher for yvDAI and yvETH

* Fix icon

* Fix exit modal

* Fixes and improvements

* Add collapse button to Toast component (#1322)

* don't expose blacklist (#1352)

* don't expose blacklist

* don't use delete keyword

* fix status endpoint types

* format

* fix server

* fix server

* Expose blacklist as undefined from public api.

Co-authored-by: Leila Wang <[email protected]>

* Jcf/hotfix yearn exit (#1356)

* - allow exiting via a different bridgeAddressId
- fix incorrect batch info shown for exiting
- more explicit name: useDefaultEnterBridgeCallData
- fix wstETH price fetch regression

* upgrade bridge clients

* explicitly upgrade ethers

* Jcf/element hotfixes (#1377)

- safe number to bigint conversion
- fix default element term apr when entering
- infer async from recipe, not interaction result

Co-authored-by: joss-aztec <[email protected]>
Co-authored-by: Lasse Herskind <[email protected]>
Co-authored-by: Jonathan Bursztyn <[email protected]>
Co-authored-by: Zachary James Williamson <[email protected]>
Co-authored-by: Josh <[email protected]>
Co-authored-by: iAmMichaelConnor <[email protected]>
Co-authored-by: Joe Andrews <[email protected]>
Co-authored-by: Leila Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ci: create a build step for noir contract artifacts
2 participants