Introduce EthAddress type in Cpp #1327
Comments
|
Very in favour of anything that adds more type safety through the system (and as you mentioned, yeah caused issues in msgpack bindings without this) |
|
stale with stuff moving to noir? |
|
Seems so. But does that mean we'll need the serialization magic in Noir? |
codygunton
pushed a commit
that referenced
this issue
Jan 23, 2024
* Audit preperation (#1305) * compiler warnings * add solhint + fix small linter issues * remove skipped tests * update rollup address * add underscores on arguments in IVerifier * JB/Move global error to toast group (#1251) * Move global error message inside toast group * Mini refactor * Mini refactor * Add deferrals * Blockchain test jest -> mocha update (#1314) * run jest-to-mocha script * Manually fix the last test + add coverage + formatting * extend mocha timeout + bump optimizer runs * decrease optimizer runs to deploy old rollup processor in testing * remove coverage package, install on demand * make solidity-coverage import a comment in hardhat config * JB/Fix settlement times (#1315) Fix batched time, fix button regression * JB/Allow for debug to be exportable (#1313) * Allow for debug to be exportable * Remove exportable debug * Rollback * Refactor * Tweak export logs * Upgrade to latest bridge clients (#1319) - Align with interface on latest bridge-clients - Correct stETH address - Calc element ROI via getTermAPR - Calc stETH via getUnderlyingAsset * Explain when to squash vs merge (#1302) * Zw/update aztec connect specs (#1048) * updated account circuit * updated account circuit formatting * updated schnorr spec * updated intro * fix typo * updates in line with PR comments and rebase Co-authored-by: Josh <[email protected]> Co-authored-by: iAmMichaelConnor <[email protected]> * Implemented rate limiting of deposits and address blacklist (#1323) * Implemented rate limiting of deposits and address blacklist * Cleanup * Additionally check num deposits in tx receiver (#1326) * Additionally check num deposits in tx receiver * Sanity check input * Additional tests (#1327) * JB/Connect yearn bridge (#1334) * Add yearn recipe * Connect yearn bridge * Fix toast z-index * Fix price estimation for yearn bridge * Take out console log * Set up yvDAI bridge config * Add styling for yearn (wip) * Add price fetcher for yvDAI and yvETH * Fix icon * Fix exit modal * Fixes and improvements * Add collapse button to Toast component (#1322) * don't expose blacklist (#1352) * don't expose blacklist * don't use delete keyword * fix status endpoint types * format * fix server * fix server * Expose blacklist as undefined from public api. Co-authored-by: Leila Wang <[email protected]> * Jcf/hotfix yearn exit (#1356) * - allow exiting via a different bridgeAddressId - fix incorrect batch info shown for exiting - more explicit name: useDefaultEnterBridgeCallData - fix wstETH price fetch regression * upgrade bridge clients * explicitly upgrade ethers * Jcf/element hotfixes (#1377) - safe number to bigint conversion - fix default element term apr when entering - infer async from recipe, not interaction result Co-authored-by: joss-aztec <[email protected]> Co-authored-by: Lasse Herskind <[email protected]> Co-authored-by: Jonathan Bursztyn <[email protected]> Co-authored-by: Zachary James Williamson <[email protected]> Co-authored-by: Josh <[email protected]> Co-authored-by: iAmMichaelConnor <[email protected]> Co-authored-by: Joe Andrews <[email protected]> Co-authored-by: Leila Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EthAddress is the only type we have in ts that has no counterpart in cpp, which leads to some funky behaviour (and bugs!) during serialisation. We should add a simple EthAddress type to maintain a 1:1 mapping on the structures we use in ts and cpp.
The text was updated successfully, but these errors were encountered: