refactor(bb): removed powers of eta in lookup and auxiliary relations

[zac-williamson]

We previously were using powers of the plookup "eta" challenge in our lookup and auxiliary relations, to construct random linear combinations.

With protogalaxy, this becomes inefficient as each challenge is represented by a degree-1 Univariate polynomial. i.e. eta^3 is degree-3, while a completely independent challenge is degree-1.

Usages of eta^2 and eta^3 have been replaced with new challenges eta_two and eta_three

Now that the CircuitChecker uses relations, we update these as appropriately but also have to change stdlib_plonk_recursion_tests to construct and verify full proof as the widgets do not reflect changes on eta

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit c9113ec3 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,400	6,412	6,424
l1_rollup_execution_gas	585,733	585,745	585,757
l2_block_processing_time_in_ms	1,293 (+1%)	4,662 (+3%)	8,913 (+4%)
note_successful_decrypting_time_in_ms	169 (+1%)	515 (+5%)	1,006 (+4%)
note_trial_decrypting_time_in_ms	74.1 (+8%)	34.5 (-68%)	37.1 (-61%)
l2_block_building_time_in_ms	13,511	51,393 (+3%)	102,040 (+3%)
l2_block_rollup_simulation_time_in_ms	7,742 (+1%)	27,965 (+3%)	55,027 (+3%)
l2_block_public_tx_process_time_in_ms	5,749	23,375 (+3%)	46,914 (+4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,104	27,459 (+4%)
note_history_successful_decrypting_time_in_ms	1,261 (-1%)	2,414 (-1%)
note_history_trial_decrypting_time_in_ms	98.4 (-21%)	114 (-19%)
node_database_size_in_bytes	18,661,456	35,033,168
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	251 (+7%)	44,377	28,214
private-kernel-ordering	220 (+6%)	52,880	14,296
base-parity	4,487 (-2%)	128	311
root-parity	1,577	1,244	311
base-rollup	17,947 (+3%)	165,760	861
root-rollup	49.1	4,359	725
private-kernel-inner	329 (+8%)	73,794	28,214
public-kernel-app-logic	126	35,251	28,217
public-kernel-tail	169	40,928	28,217
merge-rollup	7.44 (-10%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.95	15.8 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.580	0.489 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.0 (+2%)	71.1	225	444 (-1%)	860 (+3%)	1,675 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.482 (+2%)	0.439	0.410	0.416 (-1%)	0.408 (+2%)	0.402 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	54.0 (+2%)	106 (+1%)	331 (+1%)	659 (-1%)	1,281 (+1%)	2,517	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.480 (+2%)	0.477 (+1%)	0.450 (+1%)	0.454 (-1%)	0.442 (+1%)	0.439	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	60.6
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.530

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,966	494,914

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,337	1,496 (+7%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	16.3 (+9%)	732 (+1%)

[ludamad]

nit: I've been encouraging refactor over chore unless it's really stuff like forced changes due to releases code rot etc

[maramihali]

Reviewed changes, merged master, updated to reflect changes to the codebase mostly around things having been refactored and moved to various places