refactor: messaging naming fixes

[benesjan]

Some naming fixes we discussed in our team chat and which Lasse disliked in my purge PR a few days ago.
+ nuked some stale stuff from contracts.

[benesjan]

• refactor: messaging naming fixes #5383 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://65fd807fab32b200ab8e1811--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6a7ccca5 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,424	6,424
l1_rollup_execution_gas	585,745	585,757	585,757
l2_block_processing_time_in_ms	1,299 (+1%)	4,656 (-1%)	9,269 (+6%)
note_successful_decrypting_time_in_ms	179 (+8%)	525 (-9%)	975 (-3%)
note_trial_decrypting_time_in_ms	83.8 (+17%)	42.0 (-54%)	102 (-23%)
l2_block_building_time_in_ms	17,828 (+3%)	65,283	128,948 (+1%)
l2_block_rollup_simulation_time_in_ms	7,912 (-1%)	28,247	55,435 (+2%)
l2_block_public_tx_process_time_in_ms	9,895 (+6%)	36,981	73,418

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,610 (-6%)	26,231 (-5%)
note_history_successful_decrypting_time_in_ms	1,267 (-4%)	2,452
note_history_trial_decrypting_time_in_ms	97.2 (+1%)	183 (+19%)
node_database_size_in_bytes	18,616,400	34,852,944 (-1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	239 (-3%)	44,344	28,181
private-kernel-ordering	214	52,847	14,263
base-parity	4,446 (-5%)	128	311
root-parity	1,640 (-2%)	1,244	311
base-rollup	17,970 (+1%)	165,727	861
root-rollup	50.4 (+1%)	4,359	725
private-kernel-inner	593 (-1%)	73,728	28,181
public-kernel-app-logic	400 (-1%)	35,185	28,151
public-kernel-tail	172 (-1%)	40,862	28,151
merge-rollup	8.56 (-3%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2	16.1 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.598 (+2%)	0.500 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.3 (+2%)	77.8 (+9%)	235	445 (+1%)	861	1,711 (+2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.476 (+2%)	0.481 (+9%)	0.428	0.416	0.410	0.409 (+2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.9 (+1%)	111 (+5%)	334 (-1%)	661	1,308	2,610 (+3%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.481 (+1%)	0.503 (+5%)	0.455 (-1%)	0.455	0.453	0.452 (+3%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.1
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	21,991

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,082 (-2%)	1,642

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	11.1 (+4%)	1,147 (-1%)

[fcarreiro]

Approval for public_execution_context!

(will not do a formal approval since github will let you merge and I didn't review the whole PR. I got added because of CODEOWNERS)

[sklppy88]

Thanks for fixing this, I noticed a lot of changes in the outbox stuff 😅

[LHerskind]

Tiny nit on a name of an arg in an even otherwise good 👍

[LHerskind]

The blocknumber here should probably be more specific, e.g., pointing to the l2 block, just to not confuse the value with block.number

[benesjan]

Addressed in 65ae341