refactor: Always use serialize function to get hash preimage in noir circuits or when comparing structs etc #3595

[sklppy88]

Fully resolves #3595.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5a6bcef8 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,412	6,412	6,412
l1_rollup_execution_gas	585,745	585,745	585,745
l2_block_processing_time_in_ms	1,315	4,720 (+2%)	9,045 (+3%)
note_successful_decrypting_time_in_ms	150 (-18%)	510 (+1%)	964 (+3%)
note_trial_decrypting_time_in_ms	56.2 (-39%)	30.3 (+27%)	94.2 (+48%)
l2_block_building_time_in_ms	14,057 (-1%)	52,140 (+2%)	102,454 (+3%)
l2_block_rollup_simulation_time_in_ms	8,023	28,426 (+4%)	55,171 (+4%)
l2_block_public_tx_process_time_in_ms	6,007 (-2%)	23,660 (+1%)	47,187 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,568 (+7%)	27,533 (+5%)
note_history_successful_decrypting_time_in_ms	1,259	2,427 (+1%)
note_history_trial_decrypting_time_in_ms	118 (+7%)	143 (+22%)
node_database_size_in_bytes	18,665,552	34,906,192 (-1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	235 (-2%)	44,377	28,214
private-kernel-ordering	209	52,880	14,296
base-parity	4,449	128	311
root-parity	1,613 (+3%)	1,244	311
base-rollup	17,998 (+2%)	165,760	861
root-rollup	49.9	4,359	725
private-kernel-inner	307 (-1%)	73,794	28,214
public-kernel-app-logic	126	35,251	28,217
public-kernel-tail	170 (+1%)	40,928	28,217
merge-rollup	8.40 (-8%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.1 (+2%)	16.2 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.589 (+2%)	0.501 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.2	72.6 (+2%)	232 (-2%)	456 (+2%)	871 (+3%)	1,720 (+4%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.474	0.449 (+2%)	0.422 (-2%)	0.427 (+2%)	0.415 (+3%)	0.412 (+4%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.7 (+1%)	107 (+2%)	338	669 (+1%)	1,307 (+2%)	2,613 (+4%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479 (+1%)	0.485 (+2%)	0.458 (-1%)	0.461 (+1%)	0.454 (+2%)	0.455 (+4%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.4 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.538 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	14,966	494,914

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,376 (-2%)	1,403

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	17.2 (+16%)	732 (+1%)

[benesjan]

Nice