Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Remove unused @automattic/launch package and launch store #75269

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 4, 2023

Proposed Changes

This PR removes the unused automattic/launch store and the unused @automattic/launch package.

Part of #74399. A follow-up to #73890.

Testing Instructions

  • Verify that the removed store is not in use.
  • Verify the removed package is not in use.
  • All checks should be green and Calypso should build well.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

@tyxla tyxla force-pushed the remove/launch-package branch from a030ae6 to e2bb66d Compare April 4, 2023 10:31
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit remove/launch-package on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@tyxla tyxla self-assigned this Apr 4, 2023
@tyxla tyxla added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial Packages Data-Store labels Apr 4, 2023
@tyxla tyxla marked this pull request as ready for review April 4, 2023 11:46
@tyxla tyxla requested review from a team, yansern, razvanpapadopol and alshakero April 4, 2023 11:47
@tyxla tyxla changed the title Packages: Remove unused @automattic/launch package Packages: Remove unused @automattic/launch package and launch store Apr 4, 2023
@tyxla
Copy link
Member Author

tyxla commented Apr 4, 2023

There are a few @automattic/plans-grid components that are no longer in use once this lands, but we can address them separately to keep this PR from growing indefinitely.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well and couldn't find any other usage of the code.

@tyxla tyxla force-pushed the remove/launch-package branch from 5b7d539 to 75189f8 Compare April 5, 2023 11:45
@tyxla tyxla merged commit a2e1f0e into trunk Apr 5, 2023
@tyxla tyxla deleted the remove/launch-package branch April 5, 2023 11:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 5, 2023
@daledupreez
Copy link
Contributor

@tyxla, I just merged a PR and was notified that ETK was modified, but when I went to deploy ETK, it looks like this PR hasn't been deployed yet. Could you take a look at D107274-code and maybe help me test?

I think my changes are effectively a no-op.

@noahtallen
Copy link
Contributor

@daledupreez I took a look at that diff and it looks fine. I agree, it looks like a noop. (Mostly because we removed where that store was used in a separate PR/diff, so importing it there isn't really doing anything)

@tyxla
Copy link
Member Author

tyxla commented Apr 7, 2023

I second this, it's a noop, we were just removing dead / unused code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants