-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages: Remove unused @automattic/launch
package and launch store
#75269
Conversation
a030ae6
to
e2bb66d
Compare
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
@automattic/launch
package@automattic/launch
package and launch store
There are a few |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well and couldn't find any other usage of the code.
5b7d539
to
75189f8
Compare
@tyxla, I just merged a PR and was notified that ETK was modified, but when I went to deploy ETK, it looks like this PR hasn't been deployed yet. Could you take a look at D107274-code and maybe help me test? I think my changes are effectively a no-op. |
@daledupreez I took a look at that diff and it looks fine. I agree, it looks like a noop. (Mostly because we removed where that store was used in a separate PR/diff, so importing it there isn't really doing anything) |
I second this, it's a noop, we were just removing dead / unused code. |
Proposed Changes
This PR removes the unused
automattic/launch
store and the unused@automattic/launch
package.Part of #74399. A follow-up to #73890.
Testing Instructions