Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Remove unused domain utils package #75495

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 10, 2023

Proposed Changes

While working on #74399 I realized that the getDomainSearch() selector is the only instance where the @automattic/domain-utils package is used, but that selector was unused, too (since #75269).

So, this PR removes that selector, and the @automattic/domain-utils package altogether.

Testing Instructions

Verify the removed selector and package are not in use.

@tyxla tyxla added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial Packages Data-Store labels Apr 10, 2023
@tyxla tyxla requested review from a team April 10, 2023 16:09
@tyxla tyxla self-assigned this Apr 10, 2023
@tyxla tyxla requested a review from a team as a code owner April 10, 2023 16:09
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~99 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper       -186 B  (-0.0%)      -99 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~100 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
sites-dashboard       -186 B  (-0.0%)     -100 B  (-0.1%)
settings              -186 B  (-0.0%)     -100 B  (-0.0%)
hosting               -186 B  (-0.0%)     -100 B  (-0.0%)
home                  -186 B  (-0.0%)     -100 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~100 bytes removed 📉 [gzipped])

name               parsed_size           gzip_size
async-load-design       -186 B  (-0.0%)     -100 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it doesn't appear elsewhere 👍

@tyxla tyxla merged commit 1b3488b into trunk Apr 12, 2023
@tyxla tyxla deleted the remove/unused-domain-utils-package branch April 12, 2023 10:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants