Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans Grid: Remove unused components and data stores #75388

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 6, 2023

Proposed Changes

After #74475 and #75269, we found that there are some unused components that could be removed, and thanks to that, we can remove one more unused store.

This PR removes those PlansGrid components, their unused dependencies, unused styles, as well as the unused WPCOMFeatures store.

Testing Instructions

Verify Calypso builds well and that all checks are green.

@tyxla tyxla self-assigned this Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit remove/unused-plans-grid-components on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@tyxla tyxla added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Type] Janitorial Packages Data-Store [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 6, 2023
@tyxla tyxla marked this pull request as ready for review April 6, 2023 12:44
@tyxla tyxla requested review from yansern, alshakero and a team April 6, 2023 12:44
Copy link
Contributor

@flootr flootr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan comparison feature in Calypso is still working fine 👍

@tyxla tyxla merged commit 7429b47 into trunk Apr 7, 2023
@tyxla tyxla deleted the remove/unused-plans-grid-components branch April 7, 2023 09:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data-Store [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Packages [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants