Plugin updates: Gutenberg 7.7.1

[ramonjd]

Gutenberg 7.7.1 was released on March 13, 2020.

This issue tracks progress upgrading wpcom.

With 7.7.1, we're skipping stable versions (7.4.0 (potentially), 7.5.0 and 7.6.0).

7.4.0 is currently waiting in the halls until the ongoing work on the data migration project (pbAok1-f8-p2) is complete, however the completion date is unknown with estimation 5-6 days, starting on Monday March 16th.

Gutenberg

• Install stable version: D40297-code
• Activate stable version on edge sites: D40215-code
• Activate stable version on prod: D40794-code
• Cleanup old versions of GB (D39409-code)
• Request update for AT sites (p9o2xV-N2-p2)

Other

• GB call for testing stable version: p7DVsv-8gl-p2
• E2E tests stable version PR: Gutenberg 7.7.1: Trigger E2E tests #39292 (Fixes in [Gutenberg 7.7.1]: E2E test fixes #40239)
• .com specific block patterns shipped (not a blocker, but good to have in before we release) FSE: Add block pattern infrastructure #40105
• Update the Gutenberg Plugin on WPCOM Fieldguide page under Log Of Update Attempts

Bugs encountered 🐞

• Fix issue with latest posts block fataling; Gutenberg 7.7 on wpcom; inserting "Latest Posts" block fatals #40127 Addressed in D40674-code ✅ Merged.
• E2E test fails: Fixed in [Gutenberg 7.7.1]: E2E test fixes #40239 ⚠️ Needs to be merged after upgrade
• Potential blocker if not addressed in 7.7.1 p3btAN-1dt-p2 and p3btAN-1dr-p2 Check that these have been addressed in core before we update. Fixed here D40222-code
• The "W" icon back button does not work on wpcom. (need to target it with our URL overrides.) Gutenberg 7.7.1 update on wpcom: fix back button URL #40315 ✅ Merged in [Gutenberg 7.7.1]: Fix editor close button #40329
• FSE Need to remove the "W" icon back button for dotcom-fse. Dotcom FSE: remove close button on Gutenberg 7.7 #40334 Fixed in [Gutenberg 7.7.1]: Fix editor close button #40329 ⚠️ Needs to be merged before update.
• FSE Need to update FSE back button alignment. Dotcom FSE: remove close button on Gutenberg 7.7 #40334 [Gutenberg 7.7.1]: Fix editor close button #40329 ⚠️ Needs to be merged before update.
• Small regression in starter page component button Fixed in [Gutenberg 7.7.1]: remove extra button line height on page starter site #40278 ✅ Merged.
• Positioning of header in editor on smaller screens. Gutenberg 7.7.1 update on wpcom: fix header position on mobile #40335 ✅ Merged in [Gutenberg 7.7.1]: Fix editor header layout issues on mobile & tablet view. #40361
• FSE Fix the editor frame in dotcom-fse. (Or remove the frame altogether.) fix in Fix editor frame classnames for 7.7.1 #40409
• In-editor device preview not being properly applied to responsive content See p7DVsv-8gl-p2#comment-27501 — either fix or replace with old simple "preview" button for now. Gutenberg on wpcom: fix mobile/tablet/desktop previews #40401 Fixing by switching to old preview in wpcom block editor: hide new Gutenberg preview button #40388 ✅ Merged.
• adjustments to FSE header margins [Gutenberg 7.7] Fix margin on block inserter button. #40425 ✅ Merged.

Punted after release

• Hide block patterns and their UI on .com (Block patterns: hide sidebar when no patterns are registered WordPress/gutenberg#20867) We'll keep this (p7DVsv-8gl-p2#comment-27375)
• Fix issue with re-usable block fatalling: Turning block into a reusable block breaks editor #40229 — could not be replicated
• Raise an issue for the mobile preview not working with stylesheets from different domains (p7DVsv-8gl-p2#comment-27501) (p1585038214240800-slack-gutenberg-on-dotcom)

[ramonjd]

@p-jackson pointed out the changes to the header in 7.7

Current

With 7.7 enabled

This breaks our back button pretty hard.

My uneducated guess is that we'd need to update the FSE BackButtonOverride hook method ?

Also filed as an issue here: #40065

[noahtallen]

My uneducated guess is that we'd need to update the FSE BackButtonOverride hook method ?

That override will only work for dotcom-fse sites, so I think it will need fixed elsewhere too... Trying to remember where that is 🤔

This also breaks the frame around the editor for dotcom-fse:

And the new "document sidebar" button is hidden by our staging icon

[noahtallen]

In dotcom-fse, we should probably just stick with the overridden back button and remove the W icon for now. I say this because the W icon in the template part editor won't make sense -- we still need to get back to the page editor, not back to wp-admin. And we should probably keep the back button in the page editor consistent with that for now.

[roo2]

hmmm so what's the best release process for getting neccessary fixes changes to gutenberg into this release? ( I'm thinking of this one #40127)

This is the process as I understand it:

Gutenberg PR -> Gutenberg Master -> Tag a new Gutenberg release v7.7.x -> zip file -> install on wpcom edge sites -> test -> call for testing -> make it live for everyone

The problem then is that the new Gutenberg release v7.7.x will include a whole set of commits that haven't been tested with wpcom so we almost have to restart the testing effort rather than just checking this bug off the list of known issues.

But we can also manually change the zip file right, it sounds like that's the safer solution in this case, is that what you guys were thinking?

Currently v7.7.0 is a tag on the master branch, I've seen teams create release branches for this kind of complex release and then apply or cherry-pick commits on to that branch.. but that would be a different future discussion I think.

[ramonjd]

hmmm so what's the best release process for getting neccessary fixes changes to gutenberg into this release?

For major blockers we can update the files ourselves on .com. The only headache will be making sure we file a corresponding PR on the WordPress/Gutenberg repo.

The problem then is that the new Gutenberg release v7.7.x will include a whole set of commits that haven't been tested with wpcom so we almost have to restart the testing effort rather than just checking this bug off the list of known issues.

I think we could carry on as we've been doing: deal with each release as it comes out from Gutenberg, and fixing things on our end + creating Gutenberg PRs to ensure that our changes make it into future versions.

[simison]

I'll close this — we can continue in 7.8.0 issue for the next version.