Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor frame classnames for 7.7.1 #40409

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Fix editor frame classnames for 7.7.1 #40409

merged 3 commits into from
Mar 24, 2020

Conversation

noahtallen
Copy link
Contributor

Changes proposed in this Pull Request

  • Fix dotcom-fse editor classnames for Gutenberg 7.7.1

Testing instructions

  • On an edge-stickered site, test that the dotcom-fse frame appears on an FSE site. Test that the frame still appears for non-G2 versions like 7.3 as well.

Related to #40078

@noahtallen noahtallen added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg [Team] Cylon labels Mar 24, 2020
@noahtallen noahtallen requested a review from a team March 24, 2020 19:01
@noahtallen noahtallen self-assigned this Mar 24, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/dotcom-fse-editor-frame

@ramonjd ramonjd mentioned this pull request Mar 24, 2020
Closed
23 tasks
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello noahtallen! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40751-code before merging this PR. Thank you!

vindl
vindl reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on a Dotcom-fse edge site and I'm still not seeing the frame. 🤔

simison
simison approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@simison simison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested FSE site on edge (7.7.1) and regular (7.3) and all is well.

image

@noahtallen noahtallen merged commit 90cb17f into master Mar 24, 2020
@noahtallen noahtallen deleted the fix/dotcom-fse-editor-frame branch March 24, 2020 19:46
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vindl vindl vindl approved these changes

@simison simison simison approved these changes

Assignees

@noahtallen noahtallen

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Team] Cylon [Type] Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noahtallen @matticbot @simison @vindl