Resolve compatibility issues with CustomSelectControl component styles for WordPress 6.7 #9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +144 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
vladolaru
approved these changes
Oct 30, 2024
anu-rock
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Everything checks out well 🚢
Review checklist
| Parameter | Result |
|---|---|
| Approach | ✅ All good |
| Implementation | ✅ All good |
| Automated tests | Not applicable |
| Naming | ✅ All good |
| Typing | Not applicable |
| Code comments | Not applicable |
| Changelog | ✅ All good |
| Documentation | Not applicable |
| PR description | ✅ All good |
| Testing instructions | ✅ All good |
| Manual testing | ✅ Works as expected |
Scenarios tested
| Scenario | Result | Screenshot |
|---|---|---|
| Followed the testing instructions | ✅ The MOX dropdown doesn't shift down the Continue button |  |
| Tested in mobile view - iPhone 13 Pro in Firefox | ✅ The dropdown worked as expected. |  |
| Tried scrolling in both directions in mobile view | ✅ No horizontal scroll noticed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9636
Changes proposed in this Pull Request
This PR updates the styling for the
CustomSelectControlcomponent to ensure compatibility with WordPress 6.7. In this version, the component has been completely refactored, resulting in the removal of previous styles. This update reintroduces the necessary styles to maintain a consistent appearance and functionality within the new WordPress 6.7.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge