Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve compatibility issues with CustomSelectControl component styles for WordPress 6.7 #9645

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Resolve compatibility issues with CustomSelectControl component styles for WordPress 6.7 #9645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73b8714
Fix CustomSelectControl broken styling
mordeth Oct 29, 2024
93ca68e
Add changelog
mordeth Oct 30, 2024
65a709a
Merge branch 'develop' into fix/9636-custom-select-control-styling
mordeth Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-9636-custom-select-control-styling
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Fix compatibility issues with CustomSelectControl component styles for WordPress 6.7
26 changes: 25 additions & 1 deletion client/components/custom-select-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
.wcpay.components-custom-select-control {
font-size: 13px;
color: $gray-900;
position: relative;

.components-custom-select-control__label {
display: inline-block;
Expand All @@ -12,12 +13,22 @@
margin: 0;
line-height: initial;
box-shadow: inset 0 1px 0 #f0f0f0;
align-items: center;
cursor: default;
display: grid;
grid-template-columns: auto auto;
list-style-type: none;

&.is-highlighted {
background: $gray-0;
}
}

.components-custom-select-control__item
.components-custom-select-control__item-icon {
margin-left: auto;
}

button.components-custom-select-control__button {
width: 100%;
background-color: #fff;
Expand Down Expand Up @@ -53,9 +64,22 @@
}
}

.components-custom-select-control__menu[aria-hidden='true'] {
display: none;
}

.components-custom-select-control__menu {
margin: -1px 1px;
border-color: $gray-300;
background-color: #fff;
border: 1px solid $gray-300;
border-radius: 2px;
max-height: 300px;
min-width: 100%;
outline: none;
overflow: auto;
padding: 0;
position: absolute;
transition: none;
z-index: 1000000;
}
}
Loading