Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WordPress 6.7] UI issues with CustomSelectControl #9636

Closed
ilyasfoo opened this issue Oct 28, 2024 · 3 comments · Fixed by #9645
Closed

[WordPress 6.7] UI issues with CustomSelectControl #9636

ilyasfoo opened this issue Oct 28, 2024 · 3 comments · Fixed by #9645
Assignees
Labels
focus: account lifecycle type: bug The issue is a confirmed bug.

Comments

@ilyasfoo
Copy link
Contributor

Describe the bug

UI issues with CustomSelectControl is observable with WordPress 6.7-RC1:

  • The modal rendered disrupts the flow of the screen (elements pushed downwards when it's opened)
  • Border seems missing
  • Cursor shows text select when hovering over texts in dropdown items
  • Checkmark icon to show selected item is rendered outside of intended area

This seems to be exclusively visual bug, no issue found with the dropdown's functionality.

To Reproduce

  1. Use WordPress Beta Tester plugin and update to WordPress 6.7-RC1
  2. Go to KYC screen
  3. Click on any dropdown
  4. Observe the issues

Actual behavior

Expected behavior

Desktop (please complete the following information):

  • OS: MacOS 14.4.1 (23E224)
  • Browser Brave browser
  • Version v1.71.118
@ilyasfoo ilyasfoo added the type: bug The issue is a confirmed bug. label Oct 28, 2024
@ilyasfoo
Copy link
Contributor Author

ilyasfoo commented Oct 28, 2024

Hey, @ismaeldcom 👋

Tagging you because I saw your name in CustomSelectControl commit history, found this bug while doing testing for WordPress 6.7 readiness. pcShBQ-2qf-p2

@ismaeldcom
Copy link
Contributor

ismaeldcom commented Oct 28, 2024

Hi @ilyasfoo! I pretty much work with the server and MC since I switched to Sigma and I don't currently have the client set up to quickly look at this issue, so it will probably be better to ping @Automattic/moltres 🙂

@mordeth mordeth self-assigned this Oct 28, 2024
@mordeth
Copy link
Contributor

mordeth commented Oct 28, 2024

@ilyasfoo Thank you for creating the issue! I’ve assigned it to myself and will also review all instances where CustomSelectControl is used during onboarding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: account lifecycle type: bug The issue is a confirmed bug.
Projects
None yet
5 participants