-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch: Fix subscription renewals exceptions by reverting billing address related PRs #8689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpressutto5
changed the title
Revert "Patch: Fix subscription renewals exceptions (#8683)"
Patch: Fix subscription renewals exceptions
Apr 22, 2024
gpressutto5
changed the title
Patch: Fix subscription renewals exceptions
Patch: Fix subscription renewals exceptions by reverting billing address related PRs
Apr 22, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
Co-authored-by: Timur Karimov <[email protected]> Co-authored-by: Daniel Mallory <[email protected]> Co-authored-by: Daniel Mallory <[email protected]>
This was referenced Apr 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p1713795759269129/1713299466.129449-slack-CGGCLBN58
Fixes #8678
Reintroduces #5951
Reintroduces #8158
Changes proposed in this Pull Request
This PR reverts everything related to updating billing address for saved cards before paying.
Revert "Patch: Fix subscription renewals exceptions (#8683)"
Revert "Filtering billing details from order based on checkout fields (#8459)"
Revert "Remove filtering of billing address details (#8257)"
Revert "Avoid updating billing details for legacy card objects (#8664)"
Revert "Sending payment_method_update_data param to intent API (#8226)"
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge
This reverts commit 174ea29.