Filtering billing details from order based on checkout fields #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
gpressutto5
requested review from
a team and
FangedParakeet
and removed request for
a team
Co-authored-by: Samir Merchant <[email protected]>
FangedParakeet
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Thanks for the little changes! Tested subscriptions with checkout fields removed and the renewals processed successfully. Also, tested a few regular checkout flows--regular checkouts, saved payment methods, pay for order--just to ensure no breaking changes might be lurking in here, but everything appears to be working as expected.
LGTM! 🚢
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Samir Merchant <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8352
Changes proposed in this Pull Request
In #8226 we started updating the billing address every time a saved payment method was used.
Later, in #8257, we stopped filtering the billing fields we send to prevent an issue where fields that were previously set would not update to empty.
This PR updates
get_billing_details_from_orderto return only the fields present in checkout to prevent sending required fields, such as Country, as empty.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge