Remove filtering of billing address details (#8257)

Co-authored-by: Francesco <[email protected]>
Automattic · Feb 23, 2024 · d20b82f · d20b82f
1 parent efb21dc
commit d20b82f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 1 deletion.
diff --git a/changelog/fix-billing-address-update b/changelog/fix-billing-address-update
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Fixed billing address line 2 not being updated for saved payment methods
diff --git a/includes/class-wc-payments-utils.php b/includes/class-wc-payments-utils.php
@@ -358,7 +358,6 @@ public static function get_billing_details_from_order( $order ) {
 			'phone'   => $order->get_billing_phone(),
 		];
 
-		$billing_details['address'] = array_filter( $billing_details['address'] );
 		return array_filter( $billing_details );
 	}
 

diff --git a/tests/unit/core/service/test-class-wc-payments-customer-service-api.php b/tests/unit/core/service/test-class-wc-payments-customer-service-api.php
@@ -343,6 +343,7 @@ function ( $data ): bool {
 								'city'        => $order->get_billing_city(),
 								'country'     => $order->get_billing_country(),
 								'line1'       => $order->get_billing_address_1(),
+								'line2'       => $order->get_billing_address_2(),
 								'postal_code' => $order->get_billing_postcode(),
 								'state'       => $order->get_billing_state(),
 							],

diff --git a/tests/unit/test-class-wc-payments-customer-service.php b/tests/unit/test-class-wc-payments-customer-service.php
@@ -488,6 +488,7 @@ public function test_update_payment_method_with_billing_details_from_order() {
 							'city'        => 'WooCity',
 							'country'     => Country_Code::UNITED_STATES,
 							'line1'       => 'WooAddress',
+							'line2'       => '',
 							'postal_code' => '12345',
 							'state'       => 'NY',
 						],
-Original file line number
+Diff line change
@@ Expand Up @@
     			'phone'   => $order->get_billing_phone(),
     		];
-    		$billing_details['address'] = array_filter( $billing_details['address'] );
     		return array_filter( $billing_details );
     	}
@@ Expand Down @@