Re-enable Direct-to-Checkout Feature Flag in WooPay OTP Iframe #8365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +26 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
lovo-h
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Code changes look good but the required testing instructions do not pass.
I do not believe the tests are failing due to the changes in this PR, but I wanted to confirm whether this was expected and whether this issue is being tracked elsewhere.
Testing Instructions
- Scenario 1 with
_wcpay_feature_woopay_direct_checkout = 1:- ✅ You are not auto-redirected to the WooPay checkout after navigating to Merchant checkout with an email prepopulated.
- ✅ The WooPay OTP modal does not appear.
- Scenario 2 with
_wcpay_feature_woopay_direct_checkout = 1:- ✅ The WooPay OTP modal appears after entering the email.
- ✅ If authenticated, you are auto-redirected to the WooPay checkout after entering the email.
- Scenario 3 with
_wcpay_feature_woopay_direct_checkout = 1:- ✅ The WooPay OTP modal does not appear after entering an email not associated with a WooPay account.
- ✅ You are not auto-redirected to the WooPay checkout after entering an email not associated with a WooPay account.
- Scenario 4 with
_wcpay_feature_woopay_direct_checkout = 0:- Scenario 1:
- ❌ You are auto-redirected to the WooPay checkout after navigating to Merchant checkout with an email prepopulated.
- ❌ The WooPay OTP modal does appear.
- Scenario 2:
- ✅ The WooPay OTP modal appears after entering the email.
- ✅ If authenticated, you are auto-redirected to the WooPay checkout after entering the email.
- Scenario 3:
- ✅ The WooPay OTP modal does not appear after entering an email not associated with a WooPay account.
- ✅ You are not auto-redirected to the WooPay checkout after entering an email not associated with a WooPay account.
- Scenario 1:
Video Attachments
Scenario 4 / Scenario 1 Video Attachment
20240312_woopay_reenable_direct_checkout.mp4
Scenario 4 / Scenario 1 Video Attachment Description:
- Confirms:
_wcpay_feature_woopay_direct_checkout = 0. - Confirms: Manually inputting an email redirects to WooPay checkout.
- Confirms: The expected behavior from
Scenario 4 / Scenario 1does not occur.
|
@lovo-h, the I'll create a new issue to monitor this bug. I believe we can proceed with merging this PR as it isn't the source of the malfunction. I also left a comment in the PR that introduced this condition. |
|
Issue created: #8398 |
|
@rafaelzaleski , good find.
Thank you. I agree, that sounds like a good plan 👍 |
rafaelzaleski
deleted the
fix/re-add-direct-checkout-feature-flag-to-otp-iframe
branch
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable Direct-to-Checkout Feature Flag in WooPay OTP Iframe that was removed in #8116.
Testing instructions
Follow the testing instructions from #8133.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge