Do not open the email input iframe when there is no wcpay as payment method #8116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsingyuc
requested review from
a team and
malithsen
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +54 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
malithsen
approved these changes
Feb 2, 2024
| @@ -408,7 +408,7 @@ private static function get_init_session_request( $order_id = null, $key = null, | |||
| // This uses the same logic as the Checkout block in hydrate_from_api to get the cart and checkout data. | |||
| $cart_data = ! $is_pay_for_order | |||
| ? rest_preload_api_request( [], '/wc/store/v1/cart' )['/wc/store/v1/cart']['body'] | |||
| : rest_preload_api_request( [], "/wc/store/v1/order/{$order_id}?key={$key}&billing_email={$billing_email}" )[ "/wc/store/v1/order/{$order_id}?key={$key}&billing_email={$billing_email}" ]['body']; | |||
| : rest_preload_api_request( [], "/wc/store/v1/order/" . urlencode( $order_id ) . "?key=" . urlencode( $key ) . "&billing_email=" . urlencode( $billing_email ) )[ "/wc/store/v1/order/" . urlencode( $order_id ) . "?key=" . urlencode( $key ) . "&billing_email=" . urlencode( $billing_email ) ]['body']; | |||
There was a problem hiding this comment.
Are these changes related to the fix?
There was a problem hiding this comment.
They are not. Thank you! 😅
hsingyuc
force-pushed
the
fix/open-email-input-iframe-when-no-wcpay
branch
from
8008e3b to
c631954
Compare
hsingyuc
force-pushed
the
fix/open-email-input-iframe-when-no-wcpay
branch
from
e174f9d to
b7ccd51
Compare
6 tasks
6 tasks
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7684
Fixes #8053
Changes proposed in this Pull Request
In this PR, we check the available payment methods on the checkout page. If there's no
woocommerce-payments, we don't open the login session iframe.Videos
bookings.before.mov
pre-orders.before.mov
bookings.after.mov
pre-orders.after.mov
Testing instructions
Test with WooCommerce Bookings
Test with WooCommerce Pre-Orders
Upon releasenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge