Refactor the Woopay Checkout Flow UX #8133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +21 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
rafaelzaleski
requested review from
a team and
cesarcosta99
and removed request for
a team
cesarcosta99
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
LGTM! I tested all scenarios with classic and Blocks checkouts and all passed 💯
- Scenario 1: Pre-populated Email Without Auto-Redirect
- With feature flag enabled the OTP modal is not displayed and user is not redirected ✅
- With feature flag disabled the OTP modal is displayed, and user is redirected to the WooPay checkout if they're authed ✅
- Scenario 2: Active Email Entry With WooPay Account
- With feature flag enabled ✅
- If user is authed, the user is redirected to the WooPay checkout ✅
- If user is not authed, the OTP modal is displayed ✅
- With feature flag disabled ✅
- Same as with feature flag enabled ✅
- With feature flag enabled ✅
- Scenario 3: Active Email Entry Without WooPay Account
- With feature flag enabled the OTP modal is not displayed and user is not redirected ✅
- With feature flag disabled the OTP modal is not displayed and user is not redirected ✅
All the testing confirms that all the acceptance criteria are met ✅
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 2448-gh-Automattic/woopay
Changes proposed in this Pull Request
Modifies the conditions under which shoppers are redirected to the WooPay checkout page or prompted with the OTP modal.
Testing instructions
Precondition: Enable the direct checkout feature flag.
npm run wp option update _wcpay_feature_woopay_direct_checkout 1Scenario 1: Pre-populated Email Without Auto-Redirect
Scenario 2: Active Email Entry With WooPay Account
Scenario 3: Active Email Entry Without WooPay Account
Scenario 4: Feature Flag Dependency
npm run wp option update _wcpay_feature_woopay_direct_checkout 0npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge